Bug 33926 - Add ability to specify fields allowed in a response
Summary: Add ability to specify fields allowed in a response
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-06 16:16 UTC by Kyle M Hall
Modified: 2023-11-30 16:40 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
**Sponsored by** *ByWater Solutions*
Version(s) released in:
23.11.00


Attachments
Bug 33926: Add ability to specify fields allowed in a response (6.89 KB, patch)
2023-06-06 16:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 33926: Add ability to specify fields allowed in a response (6.93 KB, patch)
2023-06-07 15:58 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 33926: Add ability to specify fields allowed in a response (6.92 KB, patch)
2023-06-08 12:05 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 33926: Add ability to specify fields allowed in a response (7.02 KB, patch)
2023-09-08 08:51 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2023-06-06 16:16:09 UTC
At this time, we can specify fields to hide in SIP response at the login level. From a security perspective, it would be useful to also be able to specify which fields are allowed in a response.
Comment 1 Kyle M Hall 2023-06-06 16:25:08 UTC
Created attachment 152053 [details] [review]
Bug 33926: Add ability to specify fields allowed in a response

At this time, we can specify fields to hide in SIP response at the login level. From a security perspective, it would be useful to also be able to specify which fields are allowed in a response.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t
Comment 2 Sam Lau 2023-06-07 15:58:48 UTC
Created attachment 152118 [details] [review]
Bug 33926: Add ability to specify fields allowed in a response

At this time, we can specify fields to hide in SIP response at the login level. From a security perspective, it would be useful to also be able to specify which fields are allowed in a response.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Kyle M Hall 2023-06-08 12:05:30 UTC
Created attachment 152172 [details] [review]
Bug 33926: Add ability to specify fields allowed in a response

At this time, we can specify fields to hide in SIP response at the login level. From a security perspective, it would be useful to also be able to specify which fields are allowed in a response.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 4 Marcel de Rooy 2023-09-08 08:43:30 UTC
I wont complain about it:

 WARN   t/db_dependent/SIP/Message.t
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 523, now: 533)
Comment 5 Marcel de Rooy 2023-09-08 08:51:13 UTC
Created attachment 155377 [details] [review]
Bug 33926: Add ability to specify fields allowed in a response

At this time, we can specify fields to hide in SIP response at the login level. From a security perspective, it would be useful to also be able to specify which fields are allowed in a response.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t

Signed-off-by: Sam Lau <samalau@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Tomás Cohen Arazi 2023-09-25 13:54:42 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-09-25 19:26:32 UTC
Enhancement not pushed to 23.05.x