Bug 35488

Summary: Placing a hold on the OPAC takes the user to their account page, but does not activate the holds tab
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: OPACAssignee: Lucas Gass <lucas>
Status: Pushed to oldstable --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, lucas, victor
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02,23.05.08
Bug Depends on:    
Bug Blocks: 35492, 35495, 35496    
Attachments: Bug 35488: Open holds tab by default on opac-user.pl after placing a hold
Bug 35488: Open holds tab by default on opac-user.pl after placing a hold
Bug 35488: Open holds tab by default on opac-user.pl after placing a hold

Description Nick Clemens (kidclamp) 2023-12-05 15:28:39 UTC
To recreate:
1 - Place a hold on the opac
2 - Note after placing the hold the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds
3 - Note the holds tab is not active
Comment 1 Lucas Gass 2023-12-05 16:41:58 UTC
Created attachment 159596 [details] [review]
Bug 35488: Open holds tab by default on opac-user.pl after placing a hold

1 - Place a hold on the opac
2 - Note after placing the hold the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds
3 - Note the holds tab is not active
4 - APPLY PATCH and restart_all
5 - Try steps 1 - 3 again, this time the holds tab should be opened.
Comment 2 Owen Leonard 2023-12-05 17:19:26 UTC
Created attachment 159601 [details] [review]
Bug 35488: Open holds tab by default on opac-user.pl after placing a hold

1 - Place a hold on the opac
2 - Note after placing the hold the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds
3 - Note the holds tab is not active
4 - APPLY PATCH and restart_all
5 - Try steps 1 - 3 again, this time the holds tab should be opened.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Victor Grousset/tuxayo 2023-12-12 19:38:59 UTC
Created attachment 159777 [details] [review]
Bug 35488: Open holds tab by default on opac-user.pl after placing a hold

1 - Place a hold on the opac
2 - Note after placing the hold the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds
3 - Note the holds tab is not active
4 - APPLY PATCH and restart_all
5 - Try steps 1 - 3 again, this time the holds tab should be opened.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Victor Grousset/tuxayo 2023-12-12 19:39:38 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 5 Katrin Fischer 2023-12-14 15:31:44 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-01-03 14:06:56 UTC
Pushed to 23.11.x for 23.11.02
Comment 7 Lucas Gass 2024-01-04 18:47:03 UTC
Backported to 23.05.x for upcoming 23.05.08