Bug 35492 - Suspending/unsuspending a hold on the OPAC takes the user to their account page, but does not activate the holds tab
Summary: Suspending/unsuspending a hold on the OPAC takes the user to their account pa...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on: 35488
Blocks:
  Show dependency treegraph
 
Reported: 2023-12-05 16:49 UTC by Lucas Gass
Modified: 2024-01-04 18:48 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02,23.05.08


Attachments
Bug 35492: Open holds tab by default on opac-user.pl after suspending a hold (1.06 KB, patch)
2023-12-05 16:52 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35492: Open holds tab by default on opac-user.pl after suspending a hold (1.11 KB, patch)
2023-12-05 17:21 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35492: Open holds tab by default on opac-user.pl after suspending a hold (1.16 KB, patch)
2023-12-13 15:03 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-12-05 16:49:27 UTC
To recreate:
1 - Go to the opac-user.pl page for a user with some holds and suspend a hold.
2 - Note after placing the hold the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds
3 - Note the holds tab is not active
Comment 1 Lucas Gass 2023-12-05 16:52:57 UTC
Created attachment 159599 [details] [review]
Bug 35492: Open holds tab by default on opac-user.pl after suspending a hold

To recreate:
1 - Go to the opac-user.pl page for a user with some holds and suspend a hold.
2 - Note after placing the hold the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds
3 - Note the holds tab is not active
4. APPLY PATCH and restart all
5. Now after suspending a hold, the refreshed page should have an active hold tab.
Comment 2 Owen Leonard 2023-12-05 17:21:06 UTC
Created attachment 159602 [details] [review]
Bug 35492: Open holds tab by default on opac-user.pl after suspending a hold

To recreate:
1. Go to the opac-user.pl page for a user with some holds and suspend
   a hold.
2. Note after placing the hold the URL is:
   http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds
3  Note the holds tab is not active
4. APPLY PATCH and restart all
5. Now after suspending a hold, the refreshed page should have an active
   hold tab.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Victor Grousset/tuxayo 2023-12-13 15:03:27 UTC
Created attachment 159805 [details] [review]
Bug 35492: Open holds tab by default on opac-user.pl after suspending a hold

To recreate:
1. Go to the opac-user.pl page for a user with some holds and suspend
   a hold.
2. Note after placing the hold the URL is:
   http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds
3  Note the holds tab is not active
4. APPLY PATCH and restart all
5. Now after suspending a hold, the refreshed page should have an active
   hold tab.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Victor Grousset/tuxayo 2023-12-13 15:03:41 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 5 Katrin Fischer 2023-12-14 15:31:47 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-01-03 14:09:38 UTC
Pushed to 23.11.x for 23.11.02
Comment 7 Lucas Gass 2024-01-04 18:48:46 UTC
Backported to 23.05.x for upcoming 23.05.08