Summary: | Accepting a suggestion hides 'pending' tab | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Acquisitions | Assignee: | Kyle M Hall <kyle> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, katrin.fischer, kyle, mathsabypro, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 4068 - Accepting a suggestion hides 'pending' tab
[SIGNED-OFF] Bug 4068 - Accepting a suggestion hides 'pending' tab Bug 4068 - Accepting a suggestion hides 'pending' tab |
Description
Chris Cormack
2010-05-21 01:22:47 UTC
this is still an issue Not only does it hide the 'pending' tab, it hides the other items on the 'accepted' tab. After accepting a suggestion the *only* item on the 'accepted' tab was the one I just accepted. Retested on current master/3.6 1) Moving a suggestion from status 'pending' to 'accepted After saving only tab 'accepted' is shown. 2) Moving a suggestion back from 'accepted' to 'pending' After saving only tab 'pending' is shown. I can go back to the normal view by clicking 'clear' in the filter on the left side. Visually nothing in the filter changes when changing a status. It still looks the same. This is still an issue. M. Saby Created attachment 27969 [details] [review] Bug 4068 - Accepting a suggestion hides 'pending' tab 1) Moving a suggestion from status 'pending' to 'accepted After saving only tab 'accepted' is shown. 2) Moving a suggestion back from 'accepted' to 'pending' After saving only tab 'pending' is shown. Test Plan: 1) Verify the bug by taking the actions listed above 2) Apply this patch 3) Verify the bug no longer exists Created attachment 27974 [details] [review] [SIGNED-OFF] Bug 4068 - Accepting a suggestion hides 'pending' tab 1) Moving a suggestion from status 'pending' to 'accepted - After saving only tab 'accepted' is shown. 2) Moving a suggestion back from 'accepted' to 'pending' - After saving only tab 'pending' is shown. Test Plan: 1) Verify the bug by taking the actions listed above 2) Apply this patch 3) Verify the bug no longer exists Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 28099 [details] [review] Bug 4068 - Accepting a suggestion hides 'pending' tab 1) Moving a suggestion from status 'pending' to 'accepted - After saving only tab 'accepted' is shown. 2) Moving a suggestion back from 'accepted' to 'pending' - After saving only tab 'pending' is shown. Test Plan: 1) Verify the bug by taking the actions listed above 2) Apply this patch 3) Verify the bug no longer exists Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> It is not very elegant but I have nothing else to suggest. Pushed to master, along with a follow-up that adds the use of URI::Escape. Thanks, Kyle! Pushed to 3.14.x, will be in 3.14.09 Pushed to 3.12.x, will be in 3.12.15 |