Bug 4068 - Accepting a suggestion hides 'pending' tab
Summary: Accepting a suggestion hides 'pending' tab
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Kyle M Hall
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-27 05:21 UTC by Nicole C. Engard
Modified: 2015-06-04 23:30 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 4068 - Accepting a suggestion hides 'pending' tab (1.61 KB, patch)
2014-05-06 12:52 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 4068 - Accepting a suggestion hides 'pending' tab (1.72 KB, patch)
2014-05-06 14:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 4068 - Accepting a suggestion hides 'pending' tab (1.78 KB, patch)
2014-05-08 14:38 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:22:47 UTC


---- Reported by nengard@gmail.com 2010-01-27 17:21:18 ----

After I accepted 1 of 2 pending suggestions the 'pending' tab disappeared from the screen making it so that I couldn't get back to it without going all the way back to the Acq page and clicking on Manage Suggestions from there.  

This appears to be linked to the 'organize by' filter on the left ... by default it filters to 'no tabs' except when you visit the page the first time the tabs are there - I think that it should default to show tabs.  Or at least keep the look and feel while I make changes.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:22 UTC  ---

This bug was previously known as _bug_ 4068 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4068

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Nicole C. Engard 2010-06-02 12:23:44 UTC
this is still an issue
Comment 2 Owen Leonard 2011-08-22 14:09:43 UTC
Not only does it hide the 'pending' tab, it hides the other items on the 'accepted' tab. After accepting a suggestion the *only* item on the 'accepted' tab was the one I just accepted.
Comment 3 Katrin Fischer 2011-10-28 18:10:10 UTC
Retested on current master/3.6

1) Moving a suggestion from status 'pending' to 'accepted 
After saving only tab 'accepted' is shown.

2) Moving a suggestion back from 'accepted' to 'pending'
After saving only tab 'pending' is shown.

I can go back to the normal view by clicking 'clear' in the filter on the left side. Visually nothing in the filter changes when changing a status. It still looks the same.
Comment 4 Mathieu Saby 2013-10-13 09:15:26 UTC
This is still an issue.

M. Saby
Comment 5 Kyle M Hall 2014-05-06 12:52:46 UTC Comment hidden (obsolete)
Comment 6 Owen Leonard 2014-05-06 14:24:33 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2014-05-08 14:38:52 UTC
Created attachment 28099 [details] [review]
Bug 4068 - Accepting a suggestion hides 'pending' tab

1) Moving a suggestion from status 'pending' to 'accepted
   - After saving only tab 'accepted' is shown.
2) Moving a suggestion back from 'accepted' to 'pending'
   - After saving only tab 'pending' is shown.

Test Plan:
1) Verify the bug by taking the actions listed above
2) Apply this patch
3) Verify the bug no longer exists

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
It is not very elegant but I have nothing else to suggest.
Comment 8 Galen Charlton 2014-05-08 16:43:18 UTC
Pushed to master, along with a follow-up that adds the use of URI::Escape.  Thanks, Kyle!
Comment 9 Fridolin Somers 2014-07-22 08:10:02 UTC
Pushed to 3.14.x, will be in 3.14.09
Comment 10 Kyle M Hall 2014-08-13 13:06:51 UTC
Pushed to 3.12.x, will be in 3.12.15