---- Reported by nengard@gmail.com 2010-01-27 17:21:18 ---- After I accepted 1 of 2 pending suggestions the 'pending' tab disappeared from the screen making it so that I couldn't get back to it without going all the way back to the Acq page and clicking on Manage Suggestions from there. This appears to be linked to the 'organize by' filter on the left ... by default it filters to 'no tabs' except when you visit the page the first time the tabs are there - I think that it should default to show tabs. Or at least keep the look and feel while I make changes. --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:22 UTC --- This bug was previously known as _bug_ 4068 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4068 Actual time not defined. Setting to 0.0 Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
this is still an issue
Not only does it hide the 'pending' tab, it hides the other items on the 'accepted' tab. After accepting a suggestion the *only* item on the 'accepted' tab was the one I just accepted.
Retested on current master/3.6 1) Moving a suggestion from status 'pending' to 'accepted After saving only tab 'accepted' is shown. 2) Moving a suggestion back from 'accepted' to 'pending' After saving only tab 'pending' is shown. I can go back to the normal view by clicking 'clear' in the filter on the left side. Visually nothing in the filter changes when changing a status. It still looks the same.
This is still an issue. M. Saby
Created attachment 27969 [details] [review] Bug 4068 - Accepting a suggestion hides 'pending' tab 1) Moving a suggestion from status 'pending' to 'accepted After saving only tab 'accepted' is shown. 2) Moving a suggestion back from 'accepted' to 'pending' After saving only tab 'pending' is shown. Test Plan: 1) Verify the bug by taking the actions listed above 2) Apply this patch 3) Verify the bug no longer exists
Created attachment 27974 [details] [review] [SIGNED-OFF] Bug 4068 - Accepting a suggestion hides 'pending' tab 1) Moving a suggestion from status 'pending' to 'accepted - After saving only tab 'accepted' is shown. 2) Moving a suggestion back from 'accepted' to 'pending' - After saving only tab 'pending' is shown. Test Plan: 1) Verify the bug by taking the actions listed above 2) Apply this patch 3) Verify the bug no longer exists Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 28099 [details] [review] Bug 4068 - Accepting a suggestion hides 'pending' tab 1) Moving a suggestion from status 'pending' to 'accepted - After saving only tab 'accepted' is shown. 2) Moving a suggestion back from 'accepted' to 'pending' - After saving only tab 'pending' is shown. Test Plan: 1) Verify the bug by taking the actions listed above 2) Apply this patch 3) Verify the bug no longer exists Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> It is not very elegant but I have nothing else to suggest.
Pushed to master, along with a follow-up that adds the use of URI::Escape. Thanks, Kyle!
Pushed to 3.14.x, will be in 3.14.09
Pushed to 3.12.x, will be in 3.12.15