Bug 4851

Summary: Batch delete shouldn't show delete button if no items were found
Product: Koha Reporter: Owen Leonard <oleonard>
Component: ToolsAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: PATCH-Sent (DO NOT USE) CC: chris, nengard
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/tools/batchMod.pl
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Screenshot of useless delete button
Proposed fix

Description Owen Leonard 2010-06-04 14:06:07 UTC
Created attachment 2215 [details]
Screenshot of useless delete button

If you submit a batch of barcodes or items and none were found, the interface still shows a "delete" button. Since there is no action which can be taken, there should be no button or suggestion that a deletion can be made.
Comment 1 Owen Leonard 2010-07-20 16:01:29 UTC
Created attachment 2395 [details] [review]
Proposed fix

- Adding template flag to indicate valid results (hidden or not)
- Clarifying warning messages based on various outcomes
Comment 2 Chris Cormack 2010-12-02 23:55:42 UTC
Patch pushed to master please test
Comment 3 MJ Ray (software.coop) 2010-12-12 19:15:59 UTC
This bug is mentioned in:
Fix for Bug 4851 - Batch delete	shouldn't show delete button if no items were found http://lists.koha-community.org/pipermail/koha-patches/2010-November/012983.html