Bug 4851 - Batch delete shouldn't show delete button if no items were found
Summary: Batch delete shouldn't show delete button if no items were found
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL: /cgi-bin/koha/tools/batchMod.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-04 14:06 UTC by Owen Leonard
Modified: 2012-10-25 22:53 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot of useless delete button (8.21 KB, image/png)
2010-06-04 14:06 UTC, Owen Leonard
Details
Proposed fix (4.39 KB, patch)
2010-07-20 16:01 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2010-06-04 14:06:07 UTC
Created attachment 2215 [details]
Screenshot of useless delete button

If you submit a batch of barcodes or items and none were found, the interface still shows a "delete" button. Since there is no action which can be taken, there should be no button or suggestion that a deletion can be made.
Comment 1 Owen Leonard 2010-07-20 16:01:29 UTC
Created attachment 2395 [details] [review]
Proposed fix

- Adding template flag to indicate valid results (hidden or not)
- Clarifying warning messages based on various outcomes
Comment 2 Chris Cormack 2010-12-02 23:55:42 UTC
Patch pushed to master please test
Comment 3 MJ Ray (software.coop) 2010-12-12 19:15:59 UTC
This bug is mentioned in:
Fix for Bug 4851 - Batch delete	shouldn't show delete button if no items were found http://lists.koha-community.org/pipermail/koha-patches/2010-November/012983.html