Bug 4996

Summary: Untranslatable strings in budget/fund toolbar
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: I18N/L10NAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: minor    
Priority: PATCH-Sent (DO NOT USE) CC: chris, gmcharlt
Version: rel_3_2   
Hardware: All   
OS: All   
URL: .../cgi-bin/koha/admin/aqbudgets.pl
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: screenshot
Proposed fix

Description Katrin Fischer 2010-07-14 07:22:18 UTC
Created attachment 2362 [details]
screenshot

Some functions are not translatable in the funds/budgets toolbar.

Edit:
- edit fund 'xxx'
- duplicate fund 'xxx'

New: 
- new fund for 'xxx'
Comment 1 Owen Leonard 2010-07-20 18:35:43 UTC
Created attachment 2396 [details] [review]
Proposed fix

I think the problem is that the template is mixing a TMPL_VAR with the string to be translated:

{ text: _("Duplicate budget '<!-- TMPL_VAR NAME="budget_period_description" -->'") }

My patch breaks that kind of construction into to parts with the translatable string separate:

{ text: _("Duplicate budget") + " '<!-- TMPL_VAR NAME="budget_period_description" -->'" }
Comment 2 Galen Charlton 2010-07-20 20:13:58 UTC
Patch pushed.  Please test and close.
Comment 3 Katrin Fischer 2011-03-06 21:24:23 UTC
Works :)