Bug 4996 - Untranslatable strings in budget/fund toolbar
Summary: Untranslatable strings in budget/fund toolbar
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: rel_3_2
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL: .../cgi-bin/koha/admin/aqbudgets.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-14 07:22 UTC by Katrin Fischer
Modified: 2012-10-25 23:03 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
screenshot (6.25 KB, image/png)
2010-07-14 07:22 UTC, Katrin Fischer
Details
Proposed fix (2.37 KB, patch)
2010-07-20 18:35 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2010-07-14 07:22:18 UTC
Created attachment 2362 [details]
screenshot

Some functions are not translatable in the funds/budgets toolbar.

Edit:
- edit fund 'xxx'
- duplicate fund 'xxx'

New: 
- new fund for 'xxx'
Comment 1 Owen Leonard 2010-07-20 18:35:43 UTC
Created attachment 2396 [details] [review]
Proposed fix

I think the problem is that the template is mixing a TMPL_VAR with the string to be translated:

{ text: _("Duplicate budget '<!-- TMPL_VAR NAME="budget_period_description" -->'") }

My patch breaks that kind of construction into to parts with the translatable string separate:

{ text: _("Duplicate budget") + " '<!-- TMPL_VAR NAME="budget_period_description" -->'" }
Comment 2 Galen Charlton 2010-07-20 20:13:58 UTC
Patch pushed.  Please test and close.
Comment 3 Katrin Fischer 2011-03-06 21:24:23 UTC
Works :)