Summary: | Double quotes in publisher name, no date cause search results links to break | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, cnighswonger, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Screenshot of the problem in the wild
Initial patch |
Created attachment 2765 [details] [review] Initial patch Patch pushed, please test This bug has a patch presently committed to HEAD and 3.2.x. Please take the appropriate action to update the status of this bug. Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter. A fix for this bug has been committed to the current development HEAD as well as released in 3.2.1. |
Created attachment 2761 [details] Screenshot of the problem in the wild To reproduce: - 260b contains a publisher name with double quotes. The example that revealed the bug: Pontificia Universidad Católica Argentina "Santa María de los Buenos Aires". Instituto de Ciencias Políticas y Relaciones Internacionales - 260c must be empty If these two conditions are met the Coins/OpenURL <span> will create invalid markup, causing the link around the title (pointing to opac-detail.pl) to be broken. Changing the escape of <!-- TMPL_VAR NAME="coins" --> to "URL" breaks Zotero integration, so that's not a solution.