Bug 5412 - Double quotes in publisher name, no date cause search results links to break
Summary: Double quotes in publisher name, no date cause search results links to break
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-16 16:14 UTC by Owen Leonard
Modified: 2010-11-30 15:54 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot of the problem in the wild (21.21 KB, image/png)
2010-11-16 16:14 UTC, Owen Leonard
Details
Initial patch (1.36 KB, patch)
2010-11-17 01:17 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2010-11-16 16:14:23 UTC
Created attachment 2761 [details]
Screenshot of the problem in the wild

To reproduce:

- 260b contains a publisher name with double quotes. The example that revealed the bug:

      Pontificia Universidad Católica Argentina "Santa María de los
      Buenos Aires". Instituto de Ciencias Políticas y Relaciones
      Internacionales

- 260c must be empty

If these two conditions are met the Coins/OpenURL <span> will create invalid markup, causing the link around the title (pointing to opac-detail.pl) to be broken.

Changing the escape of <!-- TMPL_VAR NAME="coins" --> to "URL" breaks Zotero integration, so that's not a solution.
Comment 1 Tomás Cohen Arazi 2010-11-17 01:17:04 UTC
Created attachment 2765 [details] [review]
Initial patch
Comment 2 Chris Cormack 2010-11-18 01:25:14 UTC
Patch pushed, please test
Comment 3 Chris Nighswonger 2010-11-18 03:15:35 UTC
This bug has a patch presently committed to HEAD and 3.2.x.

Please take the appropriate action to update the status of this bug.

Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.
Comment 4 Chris Nighswonger 2010-11-30 15:54:50 UTC
A fix for this bug has been committed to the current development HEAD as well as released in 3.2.1.