Bug 5720

Summary: Fixing permissions for addbiblio.pl
Product: Koha Reporter: Chris Cormack <chris>
Component: CatalogingAssignee: Paul Poulain <paul.poulain>
Status: CLOSED INVALID QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: PATCH-Sent (DO NOT USE) CC: koha.sekjal, paul.poulain
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 5574    
Attachments: Proposed Patch

Description Chris Cormack 2011-02-08 21:12:36 UTC

    
Comment 1 Chris Cormack 2011-02-08 21:16:46 UTC
Created attachment 3101 [details] [review]
Proposed Patch
Comment 2 Owen Leonard 2011-02-10 17:32:58 UTC
This patch seems to have broken the functionality of the split "Save" button allowing users to choose whether to be redirected to detail.pl or additem.pl.
Comment 3 Owen Leonard 2011-02-10 17:39:49 UTC
The permissions-related part of this patch wraps the "Change framework" form on addbiblio.pl in a check for "CAN_user_editcatalogue_edit_catalogue." If the user doesn't have "CAN_user_editcatalogue_edit_catalogue" permissions how did they get to addbiblio.pl?
Comment 4 MJ Ray (software.coop) 2011-03-02 18:48:25 UTC
This bug is mentioned in:
Bug 5720 : addbiblio: removing dead code and	managing new permissions http://lists.koha-community.org/pipermail/koha-patches/2011-February/013789.html