Bug 5720 - Fixing permissions for addbiblio.pl
Summary: Fixing permissions for addbiblio.pl
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Paul Poulain
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 5574
  Show dependency treegraph
 
Reported: 2011-02-08 21:12 UTC by Chris Cormack
Modified: 2012-10-26 00:40 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (5.35 KB, patch)
2011-02-08 21:16 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2011-02-08 21:12:36 UTC

    
Comment 1 Chris Cormack 2011-02-08 21:16:46 UTC
Created attachment 3101 [details] [review]
Proposed Patch
Comment 2 Owen Leonard 2011-02-10 17:32:58 UTC
This patch seems to have broken the functionality of the split "Save" button allowing users to choose whether to be redirected to detail.pl or additem.pl.
Comment 3 Owen Leonard 2011-02-10 17:39:49 UTC
The permissions-related part of this patch wraps the "Change framework" form on addbiblio.pl in a check for "CAN_user_editcatalogue_edit_catalogue." If the user doesn't have "CAN_user_editcatalogue_edit_catalogue" permissions how did they get to addbiblio.pl?
Comment 4 MJ Ray (software.coop) 2011-03-02 18:48:25 UTC
This bug is mentioned in:
Bug 5720 : addbiblio: removing dead code and	managing new permissions http://lists.koha-community.org/pipermail/koha-patches/2011-February/013789.html