Bug 5777

Summary: System preferences Tab content title and Save button partially translatable
Product: Koha Reporter: Bernardo Gonzalez Kriegel <bgkriegel>
Component: I18N/L10NAssignee: Frédéric Demians <f.demians>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: PATCH-Sent (DO NOT USE) CC: chris, julian.maurice
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Patch

Description Bernardo Gonzalez Kriegel 2011-02-18 20:10:24 UTC
When select a system preference tab, the content page shows a title 
and a save button below.
(ej. english version
tab "Enhanced Content" -> title "Enhanced Content preferences"
tab "Enhanced Content" -> button "Save all Enhanced Content preferences"
)

The Tab label text is translatable and located on prefs-menu.inc

The text on the content page title and the button are partially translatable, 
i.e. all EXCEPT the system preference label! 

This text has the value of parameter $tab_title, whose value is computed on intranet/cgi-bin/admin/preferences.pl.
Comment 1 Frédéric Demians 2011-02-19 10:53:31 UTC
The tab label are not extracted and place in pref .po file.
This is fixed with this patch (which also suppress some warnings):

http://lists.koha-community.org/pipermail/koha-patches/2011-February/013900.html
Comment 2 Frédéric Demians 2011-02-19 10:54:25 UTC
Created attachment 3185 [details] [review]
Patch
Comment 3 Chris Cormack 2011-02-20 07:33:22 UTC
Signed off and pushed, please test
Comment 4 Frédéric Demians 2011-02-21 08:07:42 UTC
> Signed off and pushed, please test

Thanks, it works on HEAD. Awaiting cherry-picking in 3.2. 

Bernardo: Syspref tab tables will be updated next month with March string freeze.