Bug 5865

Summary: Labels wrap incorrectly when paper width is greater than height
Product: Koha Reporter: Jared Camins-Esakov <jcamins>
Component: Label/patron card printingAssignee: Chris Nighswonger <cnighswonger>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: major    
Priority: PATCH-Sent (DO NOT USE) CC: chris, julian.maurice
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Fixes incorrect use of string comparators.
Signed-off patch

Description Jared Camins-Esakov 2011-03-14 19:55:14 UTC
If the width of a template is greater than the height of the template, labels will not wrap properly. Instead of looking like this:
1  2  3 4 5 6 7 8 9 10 11
12 13 14 (etc.)
they look like this:
1  2
3  4
5  6
7  8
9  10
11 12
13 14
Comment 1 Chris Nighswonger 2011-03-14 19:59:41 UTC
changing status as this is definitely a bug :-)
Comment 2 Chris Nighswonger 2011-03-14 20:02:18 UTC Comment hidden (obsolete)
Comment 3 Chris Nighswonger 2011-03-14 20:03:34 UTC
This was due the incorrect use of string comparators to compare numeric values. The attached patch fixes this.
Comment 4 Jared Camins-Esakov 2011-03-14 20:29:27 UTC
Created attachment 3294 [details] [review]
Signed-off patch
Comment 5 Chris Cormack 2011-03-15 09:13:20 UTC
Patch pushed, please test and mark resolved