Bug 5865 - Labels wrap incorrectly when paper width is greater than height
Summary: Labels wrap incorrectly when paper width is greater than height
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Label/patron card printing (show other bugs)
Version: unspecified
Hardware: All All
: PATCH-Sent (DO NOT USE) major (vote)
Assignee: Chris Nighswonger
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-14 19:55 UTC by Jared Camins-Esakov
Modified: 2012-10-25 23:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Fixes incorrect use of string comparators. (1.46 KB, patch)
2011-03-14 20:02 UTC, Chris Nighswonger
Details | Diff | Splinter Review
Signed-off patch (1.53 KB, patch)
2011-03-14 20:29 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2011-03-14 19:55:14 UTC
If the width of a template is greater than the height of the template, labels will not wrap properly. Instead of looking like this:
1  2  3 4 5 6 7 8 9 10 11
12 13 14 (etc.)
they look like this:
1  2
3  4
5  6
7  8
9  10
11 12
13 14
Comment 1 Chris Nighswonger 2011-03-14 19:59:41 UTC
changing status as this is definitely a bug :-)
Comment 2 Chris Nighswonger 2011-03-14 20:02:18 UTC Comment hidden (obsolete)
Comment 3 Chris Nighswonger 2011-03-14 20:03:34 UTC
This was due the incorrect use of string comparators to compare numeric values. The attached patch fixes this.
Comment 4 Jared Camins-Esakov 2011-03-14 20:29:27 UTC
Created attachment 3294 [details] [review]
Signed-off patch
Comment 5 Chris Cormack 2011-03-15 09:13:20 UTC
Patch pushed, please test and mark resolved