Summary: | waitingreserves: branchname instead of branch code | ||
---|---|---|---|
Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
Component: | Circulation | Assignee: | Kyle M Hall <kyle.m.hall> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | minor | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, gmcharlt, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Patch
Reformatted for TT and signed off proposed patch (passed QA) proposed patch, trivial follow-up |
Description
Julian Maurice
2011-04-07 14:23:45 UTC
Created attachment 3804 [details] [review] Patch Created attachment 4133 [details] [review] Reformatted for TT and signed off QA comment : The patch works as expected, but there's something strange: - <td>[% INCLUDE 'biblio-default-view.inc' biblionumber = overloo.biblionumber %][% overloo.title |html %] [% overloo.subtitle |html %] + <td>[% INCLUDE 'biblio-default-view.inc' biblionumber = reserveloo.biblionumber %][% overloo.title |html %] [% overloo.subtitle |html %] I think the move overloo => reserveloo for biblionumber is wrong = we are not in reserveloop here, so it will be always empty. I've checked, and in the overloop, the link is wrong. If I switch back to overloo.biblionumber, it's OK. I add a trivial follow-up, and mark passed QA, nothing else to add to QAing. Created attachment 4926 [details] [review] proposed patch (passed QA) Created attachment 4927 [details] [review] proposed patch, trivial follow-up Pushed, please test The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. Ok in master, and 3.4.x, marked as resolved |