Bug 6121 - waitingreserves: branchname instead of branch code
Summary: waitingreserves: branchname instead of branch code
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Kyle M Hall
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-07 14:23 UTC by Julian Maurice
Modified: 2012-10-25 23:09 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch (3.15 KB, patch)
2011-04-07 14:29 UTC, Julian Maurice
Details | Diff | Splinter Review
Reformatted for TT and signed off (3.85 KB, patch)
2011-05-17 00:24 UTC, Chris Cormack
Details | Diff | Splinter Review
proposed patch (passed QA) (3.89 KB, patch)
2011-08-10 11:47 UTC, Paul Poulain
Details | Diff | Splinter Review
proposed patch, trivial follow-up (1.46 KB, patch)
2011-08-10 11:47 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2011-04-07 14:23:45 UTC
On holds over, when cancelling hold and returning to his branch a bug fill the branchtransfers.tobranch field with the branchname instead of the branch code.
Comment 1 Julian Maurice 2011-04-07 14:29:09 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2011-05-17 00:24:33 UTC Comment hidden (obsolete)
Comment 3 Paul Poulain 2011-08-10 11:46:40 UTC
QA comment :

The patch works as expected, but there's something strange:
-                        <td>[% INCLUDE 'biblio-default-view.inc' biblionumber = overloo.biblionumber %][% overloo.title |html %] [% overloo.subtitle |html %]
+                        <td>[% INCLUDE 'biblio-default-view.inc' biblionumber = reserveloo.biblionumber %][% overloo.title |html %] [% overloo.subtitle |html %]

I think the move overloo => reserveloo for biblionumber is wrong = we are not in reserveloop here, so it will be always empty.

I've checked, and in the overloop, the link is wrong. If I switch back to overloo.biblionumber, it's OK.

I add a trivial follow-up, and mark passed QA, nothing else to add to QAing.
Comment 4 Paul Poulain 2011-08-10 11:47:19 UTC
Created attachment 4926 [details] [review]
proposed patch (passed QA)
Comment 5 Paul Poulain 2011-08-10 11:47:46 UTC
Created attachment 4927 [details] [review]
proposed patch, trivial follow-up
Comment 6 Chris Cormack 2011-09-04 08:05:48 UTC
Pushed, please test
Comment 7 Chris Nighswonger 2011-10-26 18:02:37 UTC
The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report.
Comment 8 Julian Maurice 2012-01-02 11:21:50 UTC
Ok in master, and 3.4.x, marked as resolved