On holds over, when cancelling hold and returning to his branch a bug fill the branchtransfers.tobranch field with the branchname instead of the branch code.
Created attachment 3804 [details] [review] Patch
Created attachment 4133 [details] [review] Reformatted for TT and signed off
QA comment : The patch works as expected, but there's something strange: - <td>[% INCLUDE 'biblio-default-view.inc' biblionumber = overloo.biblionumber %][% overloo.title |html %] [% overloo.subtitle |html %] + <td>[% INCLUDE 'biblio-default-view.inc' biblionumber = reserveloo.biblionumber %][% overloo.title |html %] [% overloo.subtitle |html %] I think the move overloo => reserveloo for biblionumber is wrong = we are not in reserveloop here, so it will be always empty. I've checked, and in the overloop, the link is wrong. If I switch back to overloo.biblionumber, it's OK. I add a trivial follow-up, and mark passed QA, nothing else to add to QAing.
Created attachment 4926 [details] [review] proposed patch (passed QA)
Created attachment 4927 [details] [review] proposed patch, trivial follow-up
Pushed, please test
The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report.
Ok in master, and 3.4.x, marked as resolved