Bug 6346

Summary: Patron search results should be valigned top
Product: Koha Reporter: Nicole C. Engard <nengard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: minor    
Priority: PATCH-Sent (DO NOT USE) CC: chris, katrin.fischer, paul.poulain, robin
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/members/member.pl
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: example
Proposed fix
Screenshot after patch was applied
Signed off patch
proposed patch (passed QA)

Description Nicole C. Engard 2011-05-16 19:57:36 UTC
Created attachment 4126 [details]
example

When looking at the patron search results if they have a long note you don't see the patron's name because it's valigned center. Can we valign this column to the top to make it easier to see the important info.
Comment 1 Owen Leonard 2011-05-19 19:16:37 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2011-05-22 20:13:03 UTC
Created attachment 4219 [details]
Screenshot after patch was applied

I am not sure if this is a little harder to read than before. Perhaps someone else can take a look?

Patch works and I am signing off.
Comment 3 Katrin Fischer 2011-05-22 20:13:49 UTC Comment hidden (obsolete)
Comment 4 Paul Poulain 2011-08-11 08:06:26 UTC
Created attachment 4958 [details] [review]
proposed patch (passed QA)

QA comment

trivial patch, that works fine, no code comment to do

Maybe just a comment, not related to QA : the 1st screenshot shows that, if the address is large, the comment has only a small witdh, and will be very very long. A minimal width could be set for this column.
I also notice that the OD/checkouts column has a large header ("OD/checkouts") and is almost empty (0/0 for patrons without check-out)
Comment 5 Chris Cormack 2011-08-12 01:46:53 UTC
Pushed, please test
Comment 6 Robin Sheat 2011-08-30 04:25:43 UTC
I have a theory (pending confirmation) that this really uglifies the syspref search results on chrome. It also makes it look a little worse on Firefox, but not so much that it matters terribly.
Comment 7 Robin Sheat 2011-08-31 05:51:41 UTC
OK, it appears to not be the issue in Chrome. It is in FF, but that's not a big deal. I'll mark this as fixed, given it's clearly in there.