Bug 6346 - Patron search results should be valigned top
Summary: Patron search results should be valigned top
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL: /cgi-bin/koha/members/member.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-16 19:57 UTC by Nicole C. Engard
Modified: 2012-10-25 23:09 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
example (31.18 KB, image/png)
2011-05-16 19:57 UTC, Nicole C. Engard
Details
Proposed fix (945 bytes, patch)
2011-05-19 19:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Screenshot after patch was applied (71.71 KB, image/png)
2011-05-22 20:13 UTC, Katrin Fischer
Details
Signed off patch (1018 bytes, patch)
2011-05-22 20:13 UTC, Katrin Fischer
Details | Diff | Splinter Review
proposed patch (passed QA) (1019 bytes, patch)
2011-08-11 08:06 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-05-16 19:57:36 UTC
Created attachment 4126 [details]
example

When looking at the patron search results if they have a long note you don't see the patron's name because it's valigned center. Can we valign this column to the top to make it easier to see the important info.
Comment 1 Owen Leonard 2011-05-19 19:16:37 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2011-05-22 20:13:03 UTC
Created attachment 4219 [details]
Screenshot after patch was applied

I am not sure if this is a little harder to read than before. Perhaps someone else can take a look?

Patch works and I am signing off.
Comment 3 Katrin Fischer 2011-05-22 20:13:49 UTC Comment hidden (obsolete)
Comment 4 Paul Poulain 2011-08-11 08:06:26 UTC
Created attachment 4958 [details] [review]
proposed patch (passed QA)

QA comment

trivial patch, that works fine, no code comment to do

Maybe just a comment, not related to QA : the 1st screenshot shows that, if the address is large, the comment has only a small witdh, and will be very very long. A minimal width could be set for this column.
I also notice that the OD/checkouts column has a large header ("OD/checkouts") and is almost empty (0/0 for patrons without check-out)
Comment 5 Chris Cormack 2011-08-12 01:46:53 UTC
Pushed, please test
Comment 6 Robin Sheat 2011-08-30 04:25:43 UTC
I have a theory (pending confirmation) that this really uglifies the syspref search results on chrome. It also makes it look a little worse on Firefox, but not so much that it matters terribly.
Comment 7 Robin Sheat 2011-08-31 05:51:41 UTC
OK, it appears to not be the issue in Chrome. It is in FF, but that's not a big deal. I'll mark this as fixed, given it's clearly in there.