Created attachment 4126 [details] example When looking at the patron search results if they have a long note you don't see the patron's name because it's valigned center. Can we valign this column to the top to make it easier to see the important info.
Created attachment 4194 [details] [review] Proposed fix I'm going for the nuclear option: Let's valign-top all table cells. Having vertical-align : middle really only works well if your table cells have the same height. What do you think?
Created attachment 4219 [details] Screenshot after patch was applied I am not sure if this is a little harder to read than before. Perhaps someone else can take a look? Patch works and I am signing off.
Created attachment 4220 [details] [review] Signed off patch
Created attachment 4958 [details] [review] proposed patch (passed QA) QA comment trivial patch, that works fine, no code comment to do Maybe just a comment, not related to QA : the 1st screenshot shows that, if the address is large, the comment has only a small witdh, and will be very very long. A minimal width could be set for this column. I also notice that the OD/checkouts column has a large header ("OD/checkouts") and is almost empty (0/0 for patrons without check-out)
Pushed, please test
I have a theory (pending confirmation) that this really uglifies the syspref search results on chrome. It also makes it look a little worse on Firefox, but not so much that it matters terribly.
OK, it appears to not be the issue in Chrome. It is in FF, but that's not a big deal. I'll mark this as fixed, given it's clearly in there.