Bug 7268

Summary: Templates failing translation tests
Product: Koha Reporter: Chris Cormack <chris>
Component: TemplatesAssignee: Chris Cormack <chris>
Status: CLOSED FIXED QA Contact: Ian Walls <koha.sekjal>
Severity: normal    
Priority: PATCH-Sent (DO NOT USE) CC: katrin.fischer, paul.poulain
Version: 3.6   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 7268: Fixing failing tests for translatable templates
Bug 7268: Fixing failing tests for translatable templates
[SIGNED-OFF] Bug 7268: Fixing failing tests for translatable templates

Description Chris Cormack 2011-11-27 07:15:49 UTC

    
Comment 1 Chris Cormack 2011-11-27 07:20:40 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2011-11-27 08:37:34 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2011-11-27 08:38:57 UTC
Created attachment 6426 [details] [review]
[SIGNED-OFF] Bug 7268: Fixing failing tests for translatable templates

To test run

perl xt/author/translatable-templates.t

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test runs without any complaints about the fixed templates now.
Also checked detail pages without XSLT turned on display correctly.
Comment 4 Paul Poulain 2011-11-28 11:16:14 UTC
patch pushed, we will see what jenkins says in a few minuts.

chris_n : patch can be pushed on rel_3_6 as well (see http://jenkins.koha-community.org/job/Koha_3.6.x/lastBuild/, same problem)
Comment 5 Paul Poulain 2011-11-28 11:25:04 UTC
Note that i also have pushed a patch related to how the test is made, because on localised setups, the msgmerge returns a different string. See http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=c95cbce4ce8df9d9d8f664b84a3d15a6e8e8cc57 for more details