Bug 7268 - Templates failing translation tests
Summary: Templates failing translation tests
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Chris Cormack
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-27 07:15 UTC by Chris Cormack
Modified: 2012-10-25 23:10 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7268: Fixing failing tests for translatable templates (4.54 KB, patch)
2011-11-27 07:20 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 7268: Fixing failing tests for translatable templates (4.73 KB, patch)
2011-11-27 08:37 UTC, Katrin Fischer
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7268: Fixing failing tests for translatable templates (4.74 KB, patch)
2011-11-27 08:38 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2011-11-27 07:15:49 UTC

    
Comment 1 Chris Cormack 2011-11-27 07:20:40 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2011-11-27 08:37:34 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2011-11-27 08:38:57 UTC
Created attachment 6426 [details] [review]
[SIGNED-OFF] Bug 7268: Fixing failing tests for translatable templates

To test run

perl xt/author/translatable-templates.t

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test runs without any complaints about the fixed templates now.
Also checked detail pages without XSLT turned on display correctly.
Comment 4 Paul Poulain 2011-11-28 11:16:14 UTC
patch pushed, we will see what jenkins says in a few minuts.

chris_n : patch can be pushed on rel_3_6 as well (see http://jenkins.koha-community.org/job/Koha_3.6.x/lastBuild/, same problem)
Comment 5 Paul Poulain 2011-11-28 11:25:04 UTC
Note that i also have pushed a patch related to how the test is made, because on localised setups, the msgmerge returns a different string. See http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=c95cbce4ce8df9d9d8f664b84a3d15a6e8e8cc57 for more details