Bug 7360

Summary: Importing a SQL file for frameworks based on Default Framework deletes the default framework
Product: Koha Reporter: laurenthdl <henridamien.laurent>
Component: System AdministrationAssignee: Paul Poulain <paul.poulain>
Status: CLOSED FIXED QA Contact: Ian Walls <koha.sekjal>
Severity: critical    
Priority: P3 CC: francois.charbonnier, gmcharlt, katrin.fischer
Version: 3.6   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: patch proposed
[SIGNED-OFF] Bug 7360 Import Default framework into other deletes default Framework

Description laurenthdl 2011-12-14 16:29:00 UTC
Step to reproduce : 
- export default framework as SQL
- create new framework
- Import the exported SQL file into this new framework.
Go to default framework :
It disappeared.

If some libraries want to share default frameworks, then it is a major bug.
Comment 1 laurenthdl 2011-12-14 16:34:52 UTC Comment hidden (obsolete)
Comment 2 Francois Charbonnier 2011-12-14 17:30:33 UTC
Created attachment 6792 [details] [review]
[SIGNED-OFF] Bug 7360 Import Default framework into other deletes default Framework

Step to reproduce :
- export default framework as SQL
- create new framework
- Import the exported SQL file into this new framework.
Go to default framework :
It disappeared.

If some libraries want to share default frameworks, then it is a major bug.
This patch fixes the test in order to cope with 0 character framework name.

Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com>
Comment 3 Francois Charbonnier 2011-12-14 17:34:09 UTC
tests I did :

1/ I created as many test frameworks as we have framework export choices

2/ I imported each export file within a specific test framework

3/ Each time, I checked that the default framework was still here

It works!
Comment 4 Paul Poulain 2011-12-16 17:18:27 UTC
updating severity & assigning.

I won't QA it, because it's author=BibLibre & signoff=BibLibre, but pls QA quickly, it's a critical problem for anyone who export/import the default framework !
Comment 5 Ian Walls 2012-01-11 02:24:24 UTC
Just adds support for 0 character frameworks (down from minimum 1).  Marking Passed QA
Comment 6 Paul Poulain 2012-01-13 10:53:06 UTC
Patch pushed, please test