Bug 7360 - Importing a SQL file for frameworks based on Default Framework deletes the default framework
Summary: Importing a SQL file for frameworks based on Default Framework deletes the de...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: 3.6
Hardware: All All
: P3 critical (vote)
Assignee: Paul Poulain
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-14 16:29 UTC by laurenthdl
Modified: 2019-06-27 09:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patch proposed (2.05 KB, patch)
2011-12-14 16:34 UTC, laurenthdl
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7360 Import Default framework into other deletes default Framework (2.22 KB, patch)
2011-12-14 17:30 UTC, Francois Charbonnier
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description laurenthdl 2011-12-14 16:29:00 UTC
Step to reproduce : 
- export default framework as SQL
- create new framework
- Import the exported SQL file into this new framework.
Go to default framework :
It disappeared.

If some libraries want to share default frameworks, then it is a major bug.
Comment 1 laurenthdl 2011-12-14 16:34:52 UTC Comment hidden (obsolete)
Comment 2 Francois Charbonnier 2011-12-14 17:30:33 UTC
Created attachment 6792 [details] [review]
[SIGNED-OFF] Bug 7360 Import Default framework into other deletes default Framework

Step to reproduce :
- export default framework as SQL
- create new framework
- Import the exported SQL file into this new framework.
Go to default framework :
It disappeared.

If some libraries want to share default frameworks, then it is a major bug.
This patch fixes the test in order to cope with 0 character framework name.

Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com>
Comment 3 Francois Charbonnier 2011-12-14 17:34:09 UTC
tests I did :

1/ I created as many test frameworks as we have framework export choices

2/ I imported each export file within a specific test framework

3/ Each time, I checked that the default framework was still here

It works!
Comment 4 Paul Poulain 2011-12-16 17:18:27 UTC
updating severity & assigning.

I won't QA it, because it's author=BibLibre & signoff=BibLibre, but pls QA quickly, it's a critical problem for anyone who export/import the default framework !
Comment 5 Ian Walls 2012-01-11 02:24:24 UTC
Just adds support for 0 character frameworks (down from minimum 1).  Marking Passed QA
Comment 6 Paul Poulain 2012-01-13 10:53:06 UTC
Patch pushed, please test