Summary: | Debarred message not displayed over SIP2 | ||
---|---|---|---|
Product: | Koha | Reporter: | Ian Walls <koha.sekjal> |
Component: | SIP2 | Assignee: | Ian Walls <koha.sekjal> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, gmcharlt, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Proposed Patch
Bug 7396: Debarred message not showing over SIP2 |
Description
Ian Walls
2012-01-02 16:03:59 UTC
Created attachment 7015 [details] [review] Proposed Patch Corrects "DEBARRED" to "DBARRED" in list of flags to check for messages Instructions on how to test: This assumes using stock Koha and an unmodified SIPconfig.xml. [1] Add a staff user whose username and barcode are 'term1' and whose password is 'term1'. Give it the 'circulate' permission. [2] Fire up the SIPServer. E.g., $ perl C4/SIP/SIPServer.pm C4/SIP/SIPconfig.xml & [3] Use telnet to open a SIP connection: $ telnet localhost 6001 (Further interaction is assumed to be in the context of the telnet session. Use Ctrl-] to close the connection when you're done). [4] Try logging into the terminal 9300CNterm1|COterm1|CPCPL| The expected response is '941' [5] Enter a patron information request: 6300020060329 201700Y AOCPL|AAterm1|ACterm1|ADterm1| Response should be something like: 64 00020120104 171118000000000000000000000000AOCPL|AAterm1|AE term1|BLY|CQY|CC1|PCS|PIY|AFGreetings from Koha. | Now let's say we've made term1 GNA and debarred. Response, if the patch for 7396 works, would be something like: 64YYYYY 00020120104 171606000000000000000000000000AOCPL|AAterm1|AE term1|BLY|CQY|CC1|PCS|PIN|AFGreetings from Koha. -- Borrower has no valid address. -- Borrower is Debarred.| Created attachment 7128 [details] [review] Bug 7396: Debarred message not showing over SIP2 Corrects typo in list of flags; was DEBARRED, but the actual name of the flag is DBARRED (for some reason) Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Simple Patch, cCorrects DEBARRED to DBARRED in C4/SIP/ILS/Patron.pm Passed QA patch pushed, please test This was included in the 3.6 branch prior to 3.6.4. |