If a patron account is restricted with 'debarred', no such message is displayed after the "Greetings from Koha." message in the SIP2 response. Messages for Gone No Address, Lost Card and Expired account all show; it's just the Debarred message that does not. Looks to be a typo when referencing the flags name ("DEBARRED" instead of the correct "DBARRED").
Created attachment 7015 [details] [review] Proposed Patch Corrects "DEBARRED" to "DBARRED" in list of flags to check for messages
Instructions on how to test: This assumes using stock Koha and an unmodified SIPconfig.xml. [1] Add a staff user whose username and barcode are 'term1' and whose password is 'term1'. Give it the 'circulate' permission. [2] Fire up the SIPServer. E.g., $ perl C4/SIP/SIPServer.pm C4/SIP/SIPconfig.xml & [3] Use telnet to open a SIP connection: $ telnet localhost 6001 (Further interaction is assumed to be in the context of the telnet session. Use Ctrl-] to close the connection when you're done). [4] Try logging into the terminal 9300CNterm1|COterm1|CPCPL| The expected response is '941' [5] Enter a patron information request: 6300020060329 201700Y AOCPL|AAterm1|ACterm1|ADterm1| Response should be something like: 64 00020120104 171118000000000000000000000000AOCPL|AAterm1|AE term1|BLY|CQY|CC1|PCS|PIY|AFGreetings from Koha. | Now let's say we've made term1 GNA and debarred. Response, if the patch for 7396 works, would be something like: 64YYYYY 00020120104 171606000000000000000000000000AOCPL|AAterm1|AE term1|BLY|CQY|CC1|PCS|PIN|AFGreetings from Koha. -- Borrower has no valid address. -- Borrower is Debarred.|
Created attachment 7128 [details] [review] Bug 7396: Debarred message not showing over SIP2 Corrects typo in list of flags; was DEBARRED, but the actual name of the flag is DBARRED (for some reason) Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Simple Patch, cCorrects DEBARRED to DBARRED in C4/SIP/ILS/Patron.pm Passed QA
patch pushed, please test
This was included in the 3.6 branch prior to 3.6.4.