Bug 7396 - Debarred message not displayed over SIP2
Summary: Debarred message not displayed over SIP2
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Ian Walls
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-02 16:03 UTC by Ian Walls
Modified: 2013-12-05 19:59 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (1.06 KB, patch)
2012-01-02 16:07 UTC, Ian Walls
Details | Diff | Splinter Review
Bug 7396: Debarred message not showing over SIP2 (1.11 KB, patch)
2012-01-13 07:27 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Walls 2012-01-02 16:03:59 UTC
If a patron account is restricted with 'debarred', no such message is displayed after the "Greetings from Koha." message in the SIP2 response.  Messages for Gone No Address, Lost Card and Expired account all show; it's just the Debarred message that does not.

Looks to be a typo when referencing the flags name ("DEBARRED" instead of the correct "DBARRED").
Comment 1 Ian Walls 2012-01-02 16:07:51 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2012-01-04 21:14:35 UTC
Instructions on how to test:

This assumes using stock Koha and an unmodified SIPconfig.xml.

[1] Add a staff user whose username and barcode are 'term1' and whose password is 'term1'.  Give it the 'circulate' permission.
[2] Fire up the SIPServer.  E.g.,

$ perl C4/SIP/SIPServer.pm C4/SIP/SIPconfig.xml &

[3] Use telnet to open a SIP connection:

$ telnet localhost 6001

(Further interaction is assumed to be in the context of the telnet session.  Use Ctrl-] to close the connection when you're done).

[4] Try logging into the terminal

9300CNterm1|COterm1|CPCPL|

The expected response is '941'

[5] Enter a patron information request:

6300020060329    201700Y         AOCPL|AAterm1|ACterm1|ADterm1|

Response should be something like:

64              00020120104    171118000000000000000000000000AOCPL|AAterm1|AE term1|BLY|CQY|CC1|PCS|PIY|AFGreetings from Koha. |

Now let's say we've made term1 GNA and debarred.  Response, if the patch for 7396 works, would be something like:

64YYYYY         00020120104    171606000000000000000000000000AOCPL|AAterm1|AE term1|BLY|CQY|CC1|PCS|PIN|AFGreetings from Koha.  -- Borrower has no valid address. -- Borrower is Debarred.|
Comment 3 Chris Cormack 2012-01-13 07:27:52 UTC
Created attachment 7128 [details] [review]
Bug 7396: Debarred message not showing over SIP2

Corrects typo in list of flags; was DEBARRED, but the actual name of the flag is
DBARRED (for some reason)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 4 Jonathan Druart 2012-01-13 08:19:36 UTC
Simple Patch, cCorrects DEBARRED to DBARRED in C4/SIP/ILS/Patron.pm

Passed QA
Comment 5 Paul Poulain 2012-01-13 11:17:31 UTC
patch pushed, please test
Comment 6 Jared Camins-Esakov 2012-05-23 12:41:19 UTC
This was included in the 3.6 branch prior to 3.6.4.