Bug 7450

Summary: Missing placeholders in admin/authorised_values.pl
Product: Koha Reporter: Adrien SAURAT <adrien.saurat>
Component: System AdministrationAssignee: Adrien SAURAT <adrien.saurat>
Status: CLOSED FIXED QA Contact: Paul Poulain <paul.poulain>
Severity: critical    
Priority: P5 - low CC: gmcharlt, katrin.fischer, paul.poulain
Version: 3.6   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 7013    
Attachments: proposed patch
[SIGNED-OFF] Bug 7450: missing placeholders in authorised_values.pl
[SIGNED-OFF] Bug 7450: missing placeholders in authorised_values.pl

Description Adrien SAURAT 2012-01-17 10:29:35 UTC
As seen with bug 7013, some placeholders are missing in the admin/authorised_values.pl script. This should be corrected before a solution for bug 7013 is found.
Comment 1 Adrien SAURAT 2012-01-17 11:03:26 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2012-01-22 21:14:12 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2012-01-22 21:14:32 UTC
Created attachment 7281 [details] [review]
[SIGNED-OFF] Bug 7450: missing placeholders in authorised_values.pl

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Successfully added, edited and deleted authorised values.
No problems found.
Comment 4 Paul Poulain 2012-02-03 11:02:50 UTC
QA comment
 * in fact this patch solves a security issue, of a missing SQL placeholder. Upgrading severity
 * tiny patch, passed QA
Comment 5 Paul Poulain 2012-02-03 11:16:50 UTC
patch pushed, with a follow-up to remove an unconditionnal warn that was already here (detected by my pre-applypatch git hook)
Comment 6 Jared Camins-Esakov 2012-05-23 12:58:32 UTC
This fix was included in the 3.6.x branch prior to 3.6.4.