Bug 7450 - Missing placeholders in admin/authorised_values.pl
Summary: Missing placeholders in admin/authorised_values.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: 3.6
Hardware: All All
: P5 - low critical (vote)
Assignee: Adrien SAURAT
QA Contact: Paul Poulain
URL:
Keywords:
Depends on:
Blocks: 7013
  Show dependency treegraph
 
Reported: 2012-01-17 10:29 UTC by Adrien SAURAT
Modified: 2019-06-27 09:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (2.05 KB, patch)
2012-01-17 11:03 UTC, Adrien SAURAT
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7450: missing placeholders in authorised_values.pl (2.19 KB, patch)
2012-01-22 21:14 UTC, Katrin Fischer
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7450: missing placeholders in authorised_values.pl (2.19 KB, patch)
2012-01-22 21:14 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Adrien SAURAT 2012-01-17 10:29:35 UTC
As seen with bug 7013, some placeholders are missing in the admin/authorised_values.pl script. This should be corrected before a solution for bug 7013 is found.
Comment 1 Adrien SAURAT 2012-01-17 11:03:26 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2012-01-22 21:14:12 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2012-01-22 21:14:32 UTC
Created attachment 7281 [details] [review]
[SIGNED-OFF] Bug 7450: missing placeholders in authorised_values.pl

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Successfully added, edited and deleted authorised values.
No problems found.
Comment 4 Paul Poulain 2012-02-03 11:02:50 UTC
QA comment
 * in fact this patch solves a security issue, of a missing SQL placeholder. Upgrading severity
 * tiny patch, passed QA
Comment 5 Paul Poulain 2012-02-03 11:16:50 UTC
patch pushed, with a follow-up to remove an unconditionnal warn that was already here (detected by my pre-applypatch git hook)
Comment 6 Jared Camins-Esakov 2012-05-23 12:58:32 UTC
This fix was included in the 3.6.x branch prior to 3.6.4.