Summary: | AuthorisedValueImages not displaying all images on the OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Adrien SAURAT <adrien.saurat> |
Component: | OPAC | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED INVALID | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, fridolin.somers, gitbot, janet.mcgowan, jonathan.druart, katrin.fischer, m.de.rooy, nengard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 9740 | ||
Bug Blocks: | |||
Attachments: |
Bug 7706 - use AuthorisedValueImages in opac-detail.pl
Bug 7706 - Do not display authorized value image if url is empty Bug 7706 - Show image in item lost status |
Description
Adrien SAURAT
2012-03-13 10:45:03 UTC
I tested on master today and * ccode and lost are displayed on the detail page Is not true anymore - ccode images are not showing on the detail page This is still an issue - ccode icons are not showing AuthorisedValueImages syspref description is missing some details. Fist of all, this syspref applies only if XSLT is off (Looks like DisplayOPACiconsXSLT syspref manages the case with XSLT). Looking at code, it appears that this syspref only manages the fields of biblio using authorized values, not the fields of item. This is logical because images are shown with other biblio informations, not with items. So ccode image is displayed only if defined at biblio level. In OPAC details page, items table can show an image for lost status. But there is a little bug. Adding an image for location would be an enhancement and I think it should use a new Template Toolkit plugin. Note that itemtype image is managed by noItemTypeImages. > Fist of all, this syspref applies only if XSLT is off (Looks like
DisplayOPACiconsXSLT syspref manages the case with XSLT).
Correction : it does not depend on XSLT
I found a bug on detail pages : When XSLT is on, the images are not displayed ; it works when XSLT is off. The cause of this bug is corrected by Bug 9740 : when XSLT is on, the authorized value codes are replaced by there description in all page, this affects the authorized value images. Created attachment 19722 [details] [review] Bug 7706 - use AuthorisedValueImages in opac-detail.pl AuthorisedValueImages syspref was missing from opac-details. See commit comment Created attachment 19724 [details] [review] Bug 7706 - Do not display authorized value image if url is empty Small bug : if authorized value image url is empty (not undefined) the image was shows but without src the alt was shown. Created attachment 19725 [details] [review] Bug 7706 - Show image in item lost status Small bug on lost image in detail page : See commit message. This bug depends on 9740 which is in status Failed QA (In reply to I'm just a bot from comment #9) > This bug depends on 9740 which is in status Failed QA Setting status to BLOCKED 9740 is no longer failed qa so updating status. Do we need a new patch for this? Or is this supposed to be Needs Signoff? 9740 is still "in discussion" - not sure about the patches here. Changing to needs sign off since we have patches. Sorry, this patchset references files from OPAC prog :( CONFLICT (modify/delete): koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt deleted in HEAD and modified in Bug 7706 - Do not display authorized value image if url is empty. Version Bug 7706 - Do not display authorized value image if url is empty of koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt left in tree. CONFLICT (modify/delete): koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt deleted in HEAD and modified in Bug 7706 - Do not display authorized value image if url is empty. Version Bug 7706 - Do not display authorized value image if url is empty of koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt left in tree. AuthorisedValueImages has been removed from the code recently - which makes this bug invalid. |