Bug 7888

Summary: Permission for "change password" button in circ toolbar should be "borrowers" instead of "staffaccess"
Product: Koha Reporter: Liz Rea <wizzyrea>
Component: PatronsAssignee: Liz Rea <wizzyrea>
Status: CLOSED FIXED QA Contact: Ian Walls <koha.sekjal>
Severity: minor    
Priority: P4 CC: gmcharlt, paul.poulain, smoreland, wizzyrea
Version: 3.6   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 7888 - Permission for "change password" button in circ toolbar should be "borrowers" instead of "staffaccess"
[SIGNED-OFF] Bug 7888 - Permission for "change password" button in circ toolbar should be "borrowers" instead of "staffaccess"

Description Liz Rea 2012-04-03 15:32:57 UTC
The "set password" button in the circ-toolbar.inc is now hidden from users that do not have can_user_staffaccess - I don't think this makes sense - a user with edit borrowers permission can change the password from "edit patron," so for consistency, the button should work on the same permission level.
Comment 1 Liz Rea 2012-04-03 15:41:39 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-04-03 16:03:42 UTC
Created attachment 8824 [details] [review]
[SIGNED-OFF] Bug 7888 - Permission for "change password" button in circ toolbar should be "borrowers" instead of "staffaccess"

Patch changes permisison for "change password" button in circ-toolbar.inc from staffaccess to borrowers.

To test:
- With a staff user with borrowers permission, verify the change password button is shown for a normal patron.
- With a staff user without borrowers permission, verify the change password button does not appear.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Ian Walls 2012-04-03 16:14:18 UTC
Enforces consistency on this permissions.  No other changes, easy to read, marking Passed QA
Comment 4 Liz Rea 2012-04-04 19:39:38 UTC
Wow, that was fast! Thanks! Will close when it has made it to stable.
Comment 5 Jared Camins-Esakov 2012-05-24 00:51:43 UTC
This patch will be included in 3.6.5.