The "set password" button in the circ-toolbar.inc is now hidden from users that do not have can_user_staffaccess - I don't think this makes sense - a user with edit borrowers permission can change the password from "edit patron," so for consistency, the button should work on the same permission level.
Created attachment 8822 [details] [review] Bug 7888 - Permission for "change password" button in circ toolbar should be "borrowers" instead of "staffaccess" Patch changes permisison for "change password" button in circ-toolbar.inc from staffaccess to borrowers. To test: - With a staff user with borrowers permission, verify the change password button is shown for a normal patron. - With a staff user without borrowers permission, verify the change password button does not appear.
Created attachment 8824 [details] [review] [SIGNED-OFF] Bug 7888 - Permission for "change password" button in circ toolbar should be "borrowers" instead of "staffaccess" Patch changes permisison for "change password" button in circ-toolbar.inc from staffaccess to borrowers. To test: - With a staff user with borrowers permission, verify the change password button is shown for a normal patron. - With a staff user without borrowers permission, verify the change password button does not appear. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Enforces consistency on this permissions. No other changes, easy to read, marking Passed QA
Wow, that was fast! Thanks! Will close when it has made it to stable.
This patch will be included in 3.6.5.