Summary: | <pre> block produced by showmarc.pl really not good in RTL languages | ||
---|---|---|---|
Product: | Koha | Reporter: | D Ruth Holloway <ruth> |
Component: | I18N/L10N | Assignee: | D Ruth Holloway <ruth> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 8070: Showmarc preview looks really wrongheaded RTL.
Bug 8070: Showmarc preview looks really wrongheaded RTL. Bug 8070: Showmarc preview looks really wrongheaded RTL. |
Description
D Ruth Holloway
2012-05-10 11:45:17 UTC
Created attachment 22082 [details] [review] Bug 8070: Showmarc preview looks really wrongheaded RTL. The Right Answer, according to the cataloger I spoke to, is to make it LTR when doing "raw" MARC display. To test: 1) Install this patch, then run misc/translator/translate install ar-Arab 2) search for a bib in the staff client. 3) Switch to Arabic, and click the link to the left of "MARC Preview" Created attachment 22099 [details] [review] Bug 8070: Showmarc preview looks really wrongheaded RTL. The Right Answer, according to the cataloger I spoke to, is to make it LTR when doing "raw" MARC display. To test: 1) Install this patch, then run misc/translator/translate install ar-Arab 2) search for a bib in the staff client. 3) Switch to Arabic, and click the link to the left of "MARC Preview" Signed-off-by: Owen Leonard <oleonard@myacpl.org> At first glace I was unsure about hard-coding this style in the template. Further testing indicated that this is required as the showmarc template doesn't inherit any of the CSS from the containing page. Created attachment 22111 [details] [review] Bug 8070: Showmarc preview looks really wrongheaded RTL. The Right Answer, according to the cataloger I spoke to, is to make it LTR when doing "raw" MARC display. To test: 1) Install this patch, then run misc/translator/translate install ar-Arab 2) search for a bib in the staff client. 3) Switch to Arabic, and click the link to the left of "MARC Preview" Signed-off-by: Owen Leonard <oleonard@myacpl.org> At first glace I was unsure about hard-coding this style in the template. Further testing indicated that this is required as the showmarc template doesn't inherit any of the CSS from the containing page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master. Thanks, Ruth! This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Ruth! |