Bug 8070 - <pre> block produced by showmarc.pl really not good in RTL languages
Summary: <pre> block produced by showmarc.pl really not good in RTL languages
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: D Ruth Holloway
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-10 11:45 UTC by D Ruth Holloway
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 8070: Showmarc preview looks really wrongheaded RTL. (1.19 KB, patch)
2013-10-20 17:29 UTC, D Ruth Holloway 		Details | Diff | Splinter Review
Bug 8070: Showmarc preview looks really wrongheaded RTL. (1.47 KB, patch)
2013-10-20 19:25 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 8070: Showmarc preview looks really wrongheaded RTL. (1.49 KB, patch)
2013-10-20 21:13 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description D Ruth Holloway 2012-05-10 11:45:17 UTC 
The order of things gets profoundly scrambled, and encoding is dead-wrong, for Arabic at least.  

To view, switch to Arabic templates, then find a record, and hit the "MARC" preview link.
Comment 1 D Ruth Holloway 2013-10-20 17:29:07 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-10-20 19:25:56 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall (khall) 2013-10-20 21:13:36 UTC 
Created attachment 22111 [details] [review]
Bug 8070: Showmarc preview looks really wrongheaded RTL.

The Right Answer, according to the cataloger I spoke to,
is to make it LTR when doing "raw" MARC display.

To test:

1) Install this patch, then run misc/translator/translate install ar-Arab
2) search for a bib in the staff client.
3) Switch to Arabic, and click the link to the left of "MARC Preview"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

At first glace I was unsure about hard-coding this style in the
template. Further testing indicated that this is required as the
showmarc template doesn't inherit any of the CSS from the containing
page.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Galen Charlton 2013-10-21 16:05:55 UTC 
Pushed to master.  Thanks, Ruth!
Comment 5 Tomás Cohen Arazi (tcohen) 2013-11-20 16:43:47 UTC 
This patch has been pushed to 3.12.x, will be in 3.12.7.

Thanks Ruth!