Bug 8084

Summary: Suspend Until not set on by suspend button
Product: Koha Reporter: Kyle M Hall <kyle.m.hall>
Component: Hold requestsAssignee: Ian Walls <koha.sekjal>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: chris, gmcharlt, paul.poulain
Version: 3.8   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7641
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 7641    
Bug Blocks:    
Attachments: Bug 7641 - Followup - Suspend Until not set on by suspend button.

Description Kyle M Hall 2012-05-14 12:56:47 UTC
For request.pl, there are two ways to suspend a reserve, either by using the 'suspend' button for an individual reserve, or by using the 'Update hold(s)' button with suspend until dates set.
    
If the 'suspend' button is used, any date in the 'suspend until' field is ignored.
Comment 1 Kyle M Hall 2012-05-14 12:57:08 UTC
Created attachment 9561 [details] [review]
Bug 7641 - Followup - Suspend Until not set on by suspend button.

For request.pl, there are two ways to suspend a reserve, either
by using the 'suspend' button for an individual reserve, or by
using the 'Update hold(s)' button with suspend until dates set.

If the 'suspend' button is used, any date in the 'suspend until'
field is ignored. This commit fixes this issue.

  * Add suspend_until date to suspend button link via jquery
  * Add optional date to ToggleSuspend()
  * Add KohaDates plugin where necessary

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, tested:
* suspend all holds from circ.pl
* suspend one hold from circ.pl
* suspend all holds from moremember.pl
* suspend one hold from moremember.pl
   --- NOTE: clicking suspend all holds without setting a date will mean the holds must be manually unsuspended. I'm not sure this is intentional?
* suspend a specific hold using the in-table button on reserves
* suspend a specific hold using the "update hold" button

500 error is gone.
Comment 2 Chris Cormack 2012-05-16 02:40:34 UTC
Doesn't introduce new strings, and is a bug fix for an existing slightly broken feature. Will be in 3.8.1

(Note I fixed the commit message when cherry-picking it, to contain this bug number also)