Bug 8084 - Suspend Until not set on by suspend button
Summary: Suspend Until not set on by suspend button
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: 3.8
Hardware: All All
: P2 normal
Assignee: Ian Walls
QA Contact:
URL:
Keywords:
Depends on: 7641
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-14 12:56 UTC by Kyle M Hall
Modified: 2013-12-05 19:59 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 7641 - Followup - Suspend Until not set on by suspend button. (6.92 KB, patch)
2012-05-14 12:57 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2012-05-14 12:56:47 UTC
For request.pl, there are two ways to suspend a reserve, either by using the 'suspend' button for an individual reserve, or by using the 'Update hold(s)' button with suspend until dates set.
    
If the 'suspend' button is used, any date in the 'suspend until' field is ignored.
Comment 1 Kyle M Hall 2012-05-14 12:57:08 UTC
Created attachment 9561 [details] [review]
Bug 7641 - Followup - Suspend Until not set on by suspend button.

For request.pl, there are two ways to suspend a reserve, either
by using the 'suspend' button for an individual reserve, or by
using the 'Update hold(s)' button with suspend until dates set.

If the 'suspend' button is used, any date in the 'suspend until'
field is ignored. This commit fixes this issue.

  * Add suspend_until date to suspend button link via jquery
  * Add optional date to ToggleSuspend()
  * Add KohaDates plugin where necessary

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, tested:
* suspend all holds from circ.pl
* suspend one hold from circ.pl
* suspend all holds from moremember.pl
* suspend one hold from moremember.pl
   --- NOTE: clicking suspend all holds without setting a date will mean the holds must be manually unsuspended. I'm not sure this is intentional?
* suspend a specific hold using the in-table button on reserves
* suspend a specific hold using the "update hold" button

500 error is gone.
Comment 2 Chris Cormack 2012-05-16 02:40:34 UTC
Doesn't introduce new strings, and is a bug fix for an existing slightly broken feature. Will be in 3.8.1

(Note I fixed the commit message when cherry-picking it, to contain this bug number also)