Bug 8288

Summary: showmarc.tt should not include full doc-head-close.inc
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact:
Severity: minor    
Priority: P5 - low CC: chris, koha.sekjal, paul.poulain
Version: 3.8   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 8288 - showmarc.tt should not include full doc-head-close.inc
Bug 8288 - showmarc.tt should not include full doc-head-close.inc

Description Owen Leonard 2012-06-21 19:25:17 UTC
showmarc.tt is only called by modal dialogs for previewing MARC records or card views in acquisitions and cataloging. Since it is a minimal page loaded within a page it doesn't need to load all the CSS and JS a full page does.

It also creates the possibility of unintended consequences if you have intranetuserjs triggering something on document load: the event will be triggered again when the dialog loads.
Comment 1 Owen Leonard 2012-06-22 17:33:07 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2012-06-24 07:34:00 UTC
Created attachment 10448 [details] [review]
Bug 8288 - showmarc.tt should not include full doc-head-close.inc

showmarc.tt and opac-showmarc.tt are used to load a plain view
of a MARC record and thus do not need the full set of page assets
loaded with other pages (CSS and JavaScript). Removing the
standard doc-head-close include will reduce the load time of
these pages.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 3 Ian Walls 2012-06-25 16:18:14 UTC
Template only change to remove unnecessary code loading in the showmarc.tt context.  Marking Passed QA.
Comment 4 Chris Cormack 2012-06-29 10:57:20 UTC
Bugfix pushed to 3.8.x, will be in 3.8.3