Bug 8288 - showmarc.tt should not include full doc-head-close.inc
Summary: showmarc.tt should not include full doc-head-close.inc
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-21 19:25 UTC by Owen Leonard
Modified: 2013-12-05 19:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8288 - showmarc.tt should not include full doc-head-close.inc (1.81 KB, patch)
2012-06-22 17:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8288 - showmarc.tt should not include full doc-head-close.inc (1.85 KB, patch)
2012-06-24 07:34 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-06-21 19:25:17 UTC
showmarc.tt is only called by modal dialogs for previewing MARC records or card views in acquisitions and cataloging. Since it is a minimal page loaded within a page it doesn't need to load all the CSS and JS a full page does.

It also creates the possibility of unintended consequences if you have intranetuserjs triggering something on document load: the event will be triggered again when the dialog loads.
Comment 1 Owen Leonard 2012-06-22 17:33:07 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2012-06-24 07:34:00 UTC
Created attachment 10448 [details] [review]
Bug 8288 - showmarc.tt should not include full doc-head-close.inc

showmarc.tt and opac-showmarc.tt are used to load a plain view
of a MARC record and thus do not need the full set of page assets
loaded with other pages (CSS and JavaScript). Removing the
standard doc-head-close include will reduce the load time of
these pages.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 3 Ian Walls 2012-06-25 16:18:14 UTC
Template only change to remove unnecessary code loading in the showmarc.tt context.  Marking Passed QA.
Comment 4 Chris Cormack 2012-06-29 10:57:20 UTC
Bugfix pushed to 3.8.x, will be in 3.8.3