Bug 8386

Summary: Error in duplicate detection message for authorities
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: CatalogingAssignee: Jared Camins-Esakov <jcamins>
Status: RESOLVED DUPLICATE QA Contact: Mason James <mtj>
Severity: normal    
Priority: P5 - low CC: chris, jcamins, joseanjos, m.de.rooy, mtj, paul.poulain
Version: 3.8   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 8386: Error in duplicate detection message for authorities
[SIGNED-OFF] Bug 8386: Error in duplicate detection message for authorities
Bug 8386: Error in duplicate detection message for authorities

Description Katrin Fischer 2012-07-09 06:18:43 UTC
If you create a new authority record and the name already exists in your database, you get a duplicate warning. This is good, but there is a small error in the message:

Duplicate record suspected

Is this a duplicate of HASH(0x47fa670)?
Comment 1 Jared Camins-Esakov 2012-07-09 12:01:24 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2012-07-09 19:33:59 UTC Comment hidden (obsolete)
Comment 3 Mason James 2012-07-17 03:55:54 UTC
passing QA

trivial patch, passes qa-tests OK

$ koha-qa.pl
starting perlcritic-progressive tests... OK
starting 'perl -c' syntax tests... OK
starting xt/tt_valid.t tests... OK
starting xt/author/vaild-template.t tests... OK
Comment 4 Mason James 2012-07-17 03:56:56 UTC
> This patch corrects the error message to show the title.
> 

a screen-shot would be nice here... :)
Comment 5 Chris Cormack 2012-07-18 08:00:06 UTC
Pushed to 3.8.x will be in 3.8.3
Comment 6 José Anjos 2012-08-01 21:50:39 UTC
I was trying to create a new Authority with the fowling parameters:
Lastname: Lopes,
Firstname: Francisco

I with version 3.08.03.000 I this error when I'm creating a new Authority and koha finds a possible duplicate:
Software error:
Can't use string ("Lopes, Francisco Luiz
<br/>
<br/") as a HASH ref while "strict refs" in use at /usr/share/koha/intranet/cgi-bin/authorities/authorities.pl line 613.


With version 3.08.01.000 its OK, there is no problem.

So I compare both functions and they are a bit different:
Ver: 3.08.01.000
<i>duplicateauthvalue  => $duplicateauthvalue,

Ver: 3.08.03.000
duplicateauthvalue  => $duplicateauthvalue->{authorized}->[0],

When I remove ->{authorized}->[0] it works OK.

-- 
José  Anjos
Comment 7 Jared Camins-Esakov 2012-09-09 18:41:43 UTC
Created attachment 12085 [details] [review]
Bug 8386: Error in duplicate detection message for authorities

If you create a new authority record and the name already exists in
your database, you get a duplicate warning. This is good, but there is
a small error in the message:

Duplicate record suspected
Is this a duplicate of HASH(0x47fa670)?

This patch corrects a reoccurence the error message to show the title.
Comment 8 Jared Camins-Esakov 2012-09-10 19:02:56 UTC
Tomas already fixed this, and the patch is signed off, I just missed it when I was looking yesterday.

*** This bug has been marked as a duplicate of bug 8520 ***