Instead of the main entry, authority results on the staff client show things like: "HASH(0xadef408) used for/see from: Smithsonian Institution. Arthur M. Sackler Gallery used for/see from: Sackler Gallery (Smithsonian Institution)"
Created attachment 11194 [details] [review] Bug 8520: fix authority display in staff client
Created attachment 11274 [details] [review] Bug 8520: fix authority display in staff client Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Marking as signed off, since it already was.
*** Bug 8555 has been marked as a duplicate of this bug. ***
Passed QA
Well done !
Please push. Affects 3.8 installs too.
(In reply to comment #7) > Please push. Affects 3.8 installs too. I changed the version, for chris_c
Pushed to 3.8.x, will be in 3.8.4
Created attachment 11420 [details] [review] Bug 8520: fix authority display in autocomplete
Created attachment 11421 [details] [review] Bug 8520: fix authority display in autocomplete
Created attachment 11422 [details] [review] Bug 8520: fix authority display in autocomplete
Created attachment 11423 [details] [review] Bug 8520: fix authority display in autocomplete Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
hmmm, this patch has already passed QA. i think there is no need to QA it again changing status ready for 'push to 3.8'
(In reply to comment #10) > Created attachment 11420 [details] [review] > Bug 8520: fix authority display in autocomplete Jared, this patch is surely for another bug? yes?
(In reply to comment #15) > (In reply to comment #10) > > Created attachment 11420 [details] [review] > > Bug 8520: fix authority display in autocomplete > > > Jared, this patch is surely for another bug? yes? No, same bug.
The second patch is a neede follow up.
Attachment 11423 [details]: Passed QA
Needs to be pushed, on 3.8.x TOO!
(In reply to comment #19) > Needs to be pushed, on 3.8.x TOO! Hasn't been pushed to master yet. Once its pushed to master ill push it to 3.8.x
mmm... I can't find how to test this follow-up for autocomplete. Tomas, I'm back from holiday, not completly awaken it seems, if you can share the light with me ...
(In reply to comment #21) > mmm... I can't find how to test this follow-up for autocomplete. Tomas, I'm > back from holiday, not completly awaken it seems, if you can share the light > with me ... Paul, typing something in any of the authority search fields (tested from cataloguing) should be enough. Without the patch you should see HASH(0x...) if using the autocomplete function. With the patch you will see the correct results.
(In reply to comment #21) > mmm... I can't find how to test this follow-up for autocomplete. Tomas, I'm > back from holiday, not completly awaken it seems, if you can share the light > with me ... Use autocomplete in the auth_finder plugin. Without the patch applied, you get gibberish in the dropdown. With the patch, you get valid headings. This is somewhat dependent on how fast your system is. Something happened to my VM and it no longer manages to do autocomplete. In order to test this I had to point my web browser to the autocomplete URL.
OK, got it ! patch pushed
Pushed to 3.8.x, will be in 3.8.5
Created attachment 11947 [details] [review] Bug 8520 - Authorities summary incorrect on posible duplicate notice We didn't notice this one with jcamins when we fixed this bug. Sponsored-by: Universidad Nacional de Córdoba
Created attachment 11955 [details] [review] Bug 8520 - Authorities summary incorrect on posible duplicate notice We didn't notice this one with jcamins when we fixed this bug. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
*** Bug 8386 has been marked as a duplicate of this bug. ***
> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> patch looks good, passing QA… $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 119fb5f Bug 8520 - Authorities summary incorrect on posible duplicate not authorities/authorities.pl * authorities/authorities.pl OK
follow-up "Bug 8520 - Authorities summary incorrect on posible duplicate notice (1.17 KB, patch) " pushed