Bug 8692

Summary: Authorities search form does not correspond to current search query
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: CatalogingAssignee: Fridolin Somers <fridolin.somers>
Status: CLOSED FIXED QA Contact: Jonathan Druart <jonathan.druart>
Severity: normal    
Priority: P5 - low CC: chris, jonathan.druart, m.de.rooy, paul.poulain
Version: 3.10   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4198
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10808
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Proposed patch
Bug 8692: Authorities search form does not correspond to current search query
Proposed patch (rebased master)
Bug 18692 - same with syspref TalkingTechItivaPhone

Description Fridolin Somers 2012-08-27 12:47:33 UTC
In intranet, when searching authorities :
operator (contains, start with or is), sort order and selected search tab does not correspond to current search.
Also, in search results after delete, the authority type code is missing in URL.
Also, search term is missing URL encoding.
Comment 1 Fridolin Somers 2012-08-27 13:27:01 UTC Comment hidden (obsolete)
Comment 2 Jared Camins-Esakov 2012-08-27 16:44:37 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2012-09-19 14:11:04 UTC
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc
Comment 4 Fridolin Somers 2012-09-20 08:20:57 UTC
Created attachment 12371 [details] [review]
Proposed patch (rebased master)

Rebased patch.
Comment 5 Jonathan Druart 2012-09-20 10:19:19 UTC
QA Comments:
Works as expected, nothing to say
Marked as Passed QA.
Comment 6 Paul Poulain 2012-09-20 12:10:04 UTC
Patch pushed to master
Comment 7 Chris Cormack 2013-04-20 22:38:50 UTC
Released in 3.10.0
Comment 8 Fridolin Somers 2017-06-01 15:34:14 UTC
Created attachment 63899 [details] [review]
Bug 18692 - same with syspref TalkingTechItivaPhone

Fixes misplaced columns introduced by previous patch and adds the "-" for phone
transport type.

To test:
1. Set SMSSendDriver system preference on
2. Go to intra and OPAC messaging preferences
3. By default you should see checkboxes for all messages for SMS
4. Ensure columns are not misplaced (pushing one column too much to the right)
5. Delete sms method from one of the messages in message_transports table
6. Observe that "-" is displayed instead of checkbox for that message for SMS
7. Repeat same for TalkingTechItivaPhoneNotification system preference.
   By default it may not have transports in message_transports, so make sure
   to assign some in order to have the checkboxes visible.
Comment 9 Fridolin Somers 2017-06-01 15:35:42 UTC
Comment on attachment 63899 [details] [review]
Bug 18692 - same with syspref TalkingTechItivaPhone

oups, git bz error sorry