In intranet, when searching authorities : operator (contains, start with or is), sort order and selected search tab does not correspond to current search. Also, in search results after delete, the authority type code is missing in URL. Also, search term is missing URL encoding.
Created attachment 11842 [details] [review] Proposed patch Proposed patch. I also corrected a odd bug. When searching with an empty value, the results are all authorities, but the search form gets "authtypecode" as search term. This comes form authorities-home.pl : $template->param( marclist => $query->param('marclist'), and_or => $query->param('and_or'), excluding => $query->param('excluding'), operator => $query->param('operator'), orderby => $query->param('orderby'), value => $query->param('value'), authtypecode => $query->param('authtypecode'), startfrom => $startfrom, resultsperpage => $resultsperpage, ); It appears $template->param() is an array context. $query->param('value') return an array in array context so when value is empty an empty array. So you get a wrong number of args in $template->param() (17 instead of 18), which causes a warn in error logs and "authtypecode" in value. I think one should never use $query->param() in $template->param(). If the parameter in CGI query is repeatable, parameter in template must be an array ref, and if not repeatable a string or scalar. In our case, CGI query params corresponding to search are not repeatable so there is no need to get an array of params. Test plan : ----------- In authorities module : Select an authority type, select an operator (not first one), enter a search term and select a sort order (not first one). Click on 'Submit'. => Search form does not change. Click on "Search main heading". => Search form does not change. Click on "Search all headings". => Search form does not change. Click on a page result (search must have more than 20 results). => Search form does not change. Delete an authority. => Search form does not change. Perform a search with an empty search term. => Search term in form is empty.
Created attachment 11845 [details] [review] Bug 8692: Authorities search form does not correspond to current search query Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> The correct tab is now visible on load. The problem with authtypecode showing up in the search box is specific to UNIMARC, so I could not check that it was gone, but I am comfortable signing off on this.
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc
Created attachment 12371 [details] [review] Proposed patch (rebased master) Rebased patch.
QA Comments: Works as expected, nothing to say Marked as Passed QA.
Patch pushed to master
Released in 3.10.0
Created attachment 63899 [details] [review] Bug 18692 - same with syspref TalkingTechItivaPhone Fixes misplaced columns introduced by previous patch and adds the "-" for phone transport type. To test: 1. Set SMSSendDriver system preference on 2. Go to intra and OPAC messaging preferences 3. By default you should see checkboxes for all messages for SMS 4. Ensure columns are not misplaced (pushing one column too much to the right) 5. Delete sms method from one of the messages in message_transports table 6. Observe that "-" is displayed instead of checkbox for that message for SMS 7. Repeat same for TalkingTechItivaPhoneNotification system preference. By default it may not have transports in message_transports, so make sure to assign some in order to have the checkboxes visible.
Comment on attachment 63899 [details] [review] Bug 18692 - same with syspref TalkingTechItivaPhone oups, git bz error sorry