Bug 8841

Summary: Duedates set by Returnbeforeexpiry lack HH:MM
Product: Koha Reporter: Colin Campbell <colin.campbell>
Component: CirculationAssignee: Colin Campbell <colin.campbell>
Status: CLOSED FIXED QA Contact: Paul Poulain <paul.poulain>
Severity: normal    
Priority: P5 - low CC: chris, gmcharlt, kyle.m.hall, kyle, paul.poulain
Version: 3.8   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Proposed Patch
[SIGNED-OFF] Bug 8841 Duedate should be set to end of expiry day

Description Colin Campbell 2012-09-28 10:47:14 UTC
The 'Return before expiry' syspref sets the issue duedate to the patrons expiry date. It is setting the HH:MM element to 00:00 as the expiry date lacks a time element. It should set it to the end of the patron's expiration date
Comment 1 Colin Campbell 2012-09-28 11:45:49 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2012-09-28 13:04:56 UTC
Created attachment 12578 [details] [review]
[SIGNED-OFF] Bug 8841 Duedate should be set to end of expiry day

When reducing duedate to patron's expiry date
it should be set to end of that day not 00:00
take account of the fact that the borrower
expiry date will have no hours/minutes

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Jared Camins-Esakov 2012-10-06 04:27:01 UTC
I'm pretty sure this is a bug, so marking it as such.
Comment 4 Paul Poulain 2012-10-24 16:16:58 UTC
QA comment: one line patch, fixing a bug that can happen frequently

passed QA
Comment 5 Chris Cormack 2012-10-24 20:23:12 UTC
Pushed to 3.8.x will be in 3.8.7