Bug 8841 - Duedates set by Returnbeforeexpiry lack HH:MM
Summary: Duedates set by Returnbeforeexpiry lack HH:MM
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low normal (vote)
Assignee: Colin Campbell
QA Contact: Paul Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-28 10:47 UTC by Colin Campbell
Modified: 2013-05-23 06:24 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (1.03 KB, patch)
2012-09-28 11:45 UTC, Colin Campbell
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8841 Duedate should be set to end of expiry day (1.13 KB, patch)
2012-09-28 13:04 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2012-09-28 10:47:14 UTC
The 'Return before expiry' syspref sets the issue duedate to the patrons expiry date. It is setting the HH:MM element to 00:00 as the expiry date lacks a time element. It should set it to the end of the patron's expiration date
Comment 1 Colin Campbell 2012-09-28 11:45:49 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2012-09-28 13:04:56 UTC
Created attachment 12578 [details] [review]
[SIGNED-OFF] Bug 8841 Duedate should be set to end of expiry day

When reducing duedate to patron's expiry date
it should be set to end of that day not 00:00
take account of the fact that the borrower
expiry date will have no hours/minutes

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Jared Camins-Esakov 2012-10-06 04:27:01 UTC
I'm pretty sure this is a bug, so marking it as such.
Comment 4 Paul Poulain 2012-10-24 16:16:58 UTC
QA comment: one line patch, fixing a bug that can happen frequently

passed QA
Comment 5 Chris Cormack 2012-10-24 20:23:12 UTC
Pushed to 3.8.x will be in 3.8.7