Bug 9078

Summary: is_holiday should honour holiday exceptions
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: HolidaysAssignee: Tomás Cohen Arazi <tomascohen>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P5 - low CC: chris, jcamins, kyle, liz, paul.poulain
Version: 3.10   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9074
Change sponsored?: Sponsored Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 8800    
Bug Blocks:    
Attachments: Bug 9078 - is_holiday should honour holiday exceptions
Bug 9078 - is_holiday should honour holiday exceptions
Bug 9078 - fixing exceptions broke tests
[SIGNED-OFF] Bug 9078 - is_holiday should honour holiday exceptions
[PATCH 2/3] [SIGNED-OFF] Bug 9078 - is_holiday should honour holiday
[PATCH 2/3] [SIGNED-OFF] Bug 9078 - is_holiday should honour holiday
[PATCH 3/3] [SIGNED-OFF] Bug 9078 - fixing exceptions broke tests

Description Tomás Cohen Arazi 2012-11-14 17:27:56 UTC
Just that. It doesn't right now.
Comment 1 Tomás Cohen Arazi 2012-11-21 13:50:06 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2012-11-21 14:50:26 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi 2012-11-21 15:58:07 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2012-11-21 17:30:13 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2012-11-21 17:32:34 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2012-11-21 22:12:06 UTC
Created attachment 13621 [details] [review]
[PATCH 2/3] [SIGNED-OFF] Bug 9078 - is_holiday should honour holiday
Comment 7 Katrin Fischer 2012-11-21 22:14:56 UTC
Created attachment 13622 [details] [review]
[PATCH 3/3] [SIGNED-OFF] Bug 9078 - fixing exceptions broke tests
Comment 8 Paul Poulain 2012-11-22 14:32:46 UTC
QA comment:
 * passes koha-qa.pl
 * small piece of code
 * prove t/Calendar.pm OK

passed QA
Comment 9 Jared Camins-Esakov 2012-11-22 14:36:22 UTC
This patch has been pushed to master.
Comment 10 Chris Cormack 2012-11-26 00:29:27 UTC
This fix is in in 3.10.x (was released in 3.10.0) and has been pushed to 3.8.x will be in 3.8.8
Comment 11 Liz Rea 2012-11-28 01:42:07 UTC
Patches do not apply to 3.6.x, please reopen and submit a patch for 3.6.x if necessary. 

Thanks!