Bug 9078 - is_holiday should honour holiday exceptions
Summary: is_holiday should honour holiday exceptions
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Holidays (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low normal (vote)
Assignee: Tomás Cohen Arazi
QA Contact:
URL:
Keywords:
Depends on: 8800
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-14 17:27 UTC by Tomás Cohen Arazi
Modified: 2013-12-05 20:01 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9078 - is_holiday should honour holiday exceptions (1.73 KB, patch)
2012-11-21 13:50 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 9078 - is_holiday should honour holiday exceptions (1.82 KB, patch)
2012-11-21 14:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9078 - fixing exceptions broke tests (1.11 KB, patch)
2012-11-21 15:58 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9078 - is_holiday should honour holiday exceptions (1.78 KB, patch)
2012-11-21 17:30 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PATCH 2/3] [SIGNED-OFF] Bug 9078 - is_holiday should honour holiday (1.17 KB, patch)
2012-11-21 17:32 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PATCH 2/3] [SIGNED-OFF] Bug 9078 - is_holiday should honour holiday (1.86 KB, patch)
2012-11-21 22:12 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PATCH 3/3] [SIGNED-OFF] Bug 9078 - fixing exceptions broke tests (1.24 KB, patch)
2012-11-21 22:14 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2012-11-14 17:27:56 UTC
Just that. It doesn't right now.
Comment 1 Tomás Cohen Arazi 2012-11-21 13:50:06 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2012-11-21 14:50:26 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi 2012-11-21 15:58:07 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2012-11-21 17:30:13 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2012-11-21 17:32:34 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2012-11-21 22:12:06 UTC
Created attachment 13621 [details] [review]
[PATCH 2/3] [SIGNED-OFF] Bug 9078 - is_holiday should honour holiday
Comment 7 Katrin Fischer 2012-11-21 22:14:56 UTC
Created attachment 13622 [details] [review]
[PATCH 3/3] [SIGNED-OFF] Bug 9078 - fixing exceptions broke tests
Comment 8 Paul Poulain 2012-11-22 14:32:46 UTC
QA comment:
 * passes koha-qa.pl
 * small piece of code
 * prove t/Calendar.pm OK

passed QA
Comment 9 Jared Camins-Esakov 2012-11-22 14:36:22 UTC
This patch has been pushed to master.
Comment 10 Chris Cormack 2012-11-26 00:29:27 UTC
This fix is in in 3.10.x (was released in 3.10.0) and has been pushed to 3.8.x will be in 3.8.8
Comment 11 Liz Rea 2012-11-28 01:42:07 UTC
Patches do not apply to 3.6.x, please reopen and submit a patch for 3.6.x if necessary. 

Thanks!