Summary: | DidYouMeanFromAuthorities syspref obsolete | ||
---|---|---|---|
Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
Component: | System Administration | Assignee: | Jared Camins-Esakov <jcamins> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, jcamins, jonathan.druart, melia, nengard, paul.poulain |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 9107: Remove the obsolete DidYouMeanFromAuthorities syspref
[Signed off] Bug 9107: Remove the obsolete DidYouMeanFromAuthorities syspref Bug 9107: Remove the obsolete DidYouMeanFromAuthorities syspref Bug 9107 remove the syspref from the database, as well, |
Description
Jared Camins-Esakov
2012-11-19 16:33:45 UTC
Created attachment 13532 [details] [review] Bug 9107: Remove the obsolete DidYouMeanFromAuthorities syspref Even though the DidYouMeanFromAuthorities syspref was replaced by a "Did You Mean?" configuration page, the syspref was showing up in the syspref editor on the Searching tab. Is this just master? or 3.10 too? (In reply to comment #2) > Is this just master? or 3.10 too? Both. At the moment master is 3.10 for all practical purposes, since I haven't pushed any 3.12-only patches to git.k-c.org yet. Created attachment 13540 [details] [review] [Signed off] Bug 9107: Remove the obsolete DidYouMeanFromAuthorities syspref Even though the DidYouMeanFromAuthorities syspref was replaced by a "Did You Mean?" configuration page, the syspref was showing up in the syspref editor on the Searching tab. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> To test I looked at the searching tab of the sysprefs. Before applying the patch, I could see the DidYouMeanFromAuthorities sys pref. After applying the patch, I can no longer see it. If that's all this patch does, then I think it works! Signing off. QA Comment: Remove the entry DidYouMeanFromAuthorities in a syspref description file. Marked as Passed QA. Created attachment 13543 [details] [review] Bug 9107: Remove the obsolete DidYouMeanFromAuthorities syspref Even though the DidYouMeanFromAuthorities syspref was replaced by a "Did You Mean?" configuration page, the syspref was showing up in the syspref editor on the Searching tab. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Created attachment 13544 [details] [review] Bug 9107 remove the syspref from the database, as well, The syspref has been introduced during 3.9, so only a few libraries should have it but for consistency, it must be removed QA comment: * tiny patch that just remove useless things It's better to also remove the syspref from the database as well. I've added a follow-up (with the DB version, as I'll pass QA), to remove it Lowering the severity, it's not a BLO at all This patch has been pushed to master. Patch pushed to branch 3.10.x This syspref does not appear in Master. |