Bug 9107 - DidYouMeanFromAuthorities syspref obsolete
Summary: DidYouMeanFromAuthorities syspref obsolete
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low normal (vote)
Assignee: Jared Camins-Esakov
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-19 16:33 UTC by Jared Camins-Esakov
Modified: 2013-12-05 20:01 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9107: Remove the obsolete DidYouMeanFromAuthorities syspref (1.52 KB, patch)
2012-11-19 16:38 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
[Signed off] Bug 9107: Remove the obsolete DidYouMeanFromAuthorities syspref (1.61 KB, patch)
2012-11-20 00:53 UTC, Melia Meggs
Details | Diff | Splinter Review
Bug 9107: Remove the obsolete DidYouMeanFromAuthorities syspref (1.63 KB, patch)
2012-11-20 10:45 UTC, Paul Poulain
Details | Diff | Splinter Review
Bug 9107 remove the syspref from the database, as well, (1.14 KB, patch)
2012-11-20 10:45 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2012-11-19 16:33:45 UTC
The DidYouMeanFromAuthorities syspref has been replaced by a Did You Mean? configuration page, but it's still showing up in the Searching sysprefs tab on Master.
Comment 1 Jared Camins-Esakov 2012-11-19 16:38:17 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2012-11-19 18:09:05 UTC
Is this just master? or 3.10 too?
Comment 3 Jared Camins-Esakov 2012-11-19 18:11:24 UTC
(In reply to comment #2)
> Is this just master? or 3.10 too?

Both. At the moment master is 3.10 for all practical purposes, since I haven't pushed any 3.12-only patches to git.k-c.org yet.
Comment 4 Melia Meggs 2012-11-20 00:53:02 UTC Comment hidden (obsolete)
Comment 5 Melia Meggs 2012-11-20 00:54:42 UTC
To test I looked at the searching tab of the sysprefs.

Before applying the patch, I could see the DidYouMeanFromAuthorities sys pref.

After applying the patch, I can no longer see it.

If that's all this patch does, then I think it works!  Signing off.
Comment 6 Jonathan Druart 2012-11-20 10:27:53 UTC
QA Comment:

Remove the entry DidYouMeanFromAuthorities in a syspref description file.

Marked as Passed QA.
Comment 7 Paul Poulain 2012-11-20 10:45:07 UTC
Created attachment 13543 [details] [review]
Bug 9107: Remove the obsolete DidYouMeanFromAuthorities syspref

Even though the DidYouMeanFromAuthorities syspref was replaced by a "Did
You Mean?" configuration page, the syspref was showing up in the
syspref editor on the Searching tab.

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Comment 8 Paul Poulain 2012-11-20 10:45:10 UTC
Created attachment 13544 [details] [review]
Bug 9107 remove the syspref from the database, as well,

The syspref has been introduced during 3.9, so only a few libraries should have it but for consistency, it must be removed
Comment 9 Paul Poulain 2012-11-20 10:46:55 UTC
QA comment:
 * tiny patch that just remove useless things

It's better to also remove the syspref from the database as well. I've added a follow-up (with the DB version, as I'll pass QA), to remove it

Lowering the severity, it's not a BLO at all
Comment 10 Jared Camins-Esakov 2012-11-20 12:14:35 UTC
This patch has been pushed to master.
Comment 11 Paul Poulain 2012-11-20 15:24:56 UTC
Patch pushed to branch 3.10.x
Comment 12 Jared Camins-Esakov 2012-12-03 13:11:58 UTC
This syspref does not appear in Master.