Bug 9444

Summary: Use DataTables in system preferences editor
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Jonathan Druart <jonathan.druart>
Severity: enhancement    
Priority: P5 - low CC: bgkriegel, jonathan.druart
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/admin/preferences.pl
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 9444 - Use DataTables in system preferences editor
Bug 9444 - Use DataTables in system preferences editor
Bug 9444 [Revised] Use DataTables in system preferences editor
[SIGNED-OFF] Bug 9444 [Revised] Use DataTables in system preferences editor
Bug 9444 [Revised] Use DataTables in system preferences editor
[SIGNED-OFF] Bug 9444 [Revised] Use DataTables in system preferences editor
Bug 9444 [Revised] Use DataTables in system preferences editor

Description Owen Leonard 2013-01-22 17:17:16 UTC
The "new" system preferences editor uses the old tablesorter plugin. It should use the DataTables plugin instead.
Comment 1 Owen Leonard 2013-01-22 17:20:54 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2013-01-23 08:37:34 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2013-02-26 16:21:31 UTC Comment hidden (obsolete)
Comment 4 Bernardo Gonzalez Kriegel 2013-02-27 23:37:59 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2013-02-28 15:46:50 UTC
This patch breaks the collapse/expand action. The datatable plugin adds a div element around the table :-/

Marked as Failed QA.
Comment 6 Owen Leonard 2013-03-01 19:52:45 UTC Comment hidden (obsolete)
Comment 7 Bernardo Gonzalez Kriegel 2013-03-01 21:29:27 UTC Comment hidden (obsolete)
Comment 8 Jonathan Druart 2013-03-04 09:16:15 UTC
QA comment:

Now all work great.
This patch add datatable on the syspref tables. The first column (syspref names) is sortable.

Marked as Passed QA.
Comment 9 Jonathan Druart 2013-03-04 09:16:35 UTC
Created attachment 15841 [details] [review]
Bug 9444 [Revised] Use DataTables in system preferences editor

Replace the tablesorter plugin with the DataTables plugin in the
"new" system preferences editor.

To test, open the system preferences editor on any tab other than Local
Use. Confirm that table sorting works correctly within each section. In
this configuration there should be no pager and no results filtering.

Revision corrects template path to datatables assets.
Further revision fixes section-collapse JS

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. Collapsing restored. No errors.
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 10 Jared Camins-Esakov 2013-03-07 15:43:30 UTC
This patch has been pushed to master.