Bug 9616

Summary: Replace YUI menu on patrons page with Bootstrap
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: bgkriegel, katrin.fischer
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/members/members-home.pl
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 9616 - Replace YUI menu on patrons page with Bootstrap
Bug 9616 - Replace YUI menu on patrons page with Bootstrap
[SIGNED-OFF] Bug 9616 - Replace YUI menu on patrons page with Bootstrap
[PASSED QA] Bug 9616 - Replace YUI menu on patrons page with Bootstrap

Description Owen Leonard 2013-02-15 14:38:23 UTC
The "new patron" menu on the patrons page is constructed using YUI. It should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-15 14:41:55 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-15 15:10:10 UTC
Bug 9420 has been pushed to master. 
Why this patch removes conflicting lines from that bug?

-<<<<<<< HEAD
...
-=======
...
->>>>>>> Bug 9420 [Revised] Work on Bootstrap for Koha
-<<<<<<< HEAD
...
->>>>>>> Bug 9420 [Revised] Work on Bootstrap for Koha
Comment 3 Owen Leonard 2013-02-15 15:41:40 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2013-02-15 15:42:32 UTC
Sorry for the bad merge errors in the previous patch!
Comment 5 Bernardo Gonzalez Kriegel 2013-02-15 15:52:00 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2013-02-17 11:14:22 UTC
Created attachment 15452 [details] [review]
[PASSED QA] Bug 9616 - Replace YUI menu on patrons page with Bootstrap

This patch converts the toolbar include file used to create the "New
patron" menu to Bootstrap, replacing YUI button and menu code
with Bootstrap markup.

To test, view any page which uses patron-toolbar.inc (members-home.pl or
circulation.pl after searching for a non-existent patron). Button and
menu should look correct and work correctly with the AddPatronLists
preference in both states.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Works as described. No errors. Looks very good!

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, no problems found.
Comment 7 Jared Camins-Esakov 2013-02-18 12:57:50 UTC
This patch has been pushed to master.