Bug 9616 - Replace YUI menu on patrons page with Bootstrap
Summary: Replace YUI menu on patrons page with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/members/members-home.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-15 14:38 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9616 - Replace YUI menu on patrons page with Bootstrap (6.62 KB, patch)
2013-02-15 14:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9616 - Replace YUI menu on patrons page with Bootstrap (5.00 KB, patch)
2013-02-15 15:41 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9616 - Replace YUI menu on patrons page with Bootstrap (5.08 KB, patch)
2013-02-15 15:52 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9616 - Replace YUI menu on patrons page with Bootstrap (5.18 KB, patch)
2013-02-17 11:14 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-15 14:38:23 UTC
The "new patron" menu on the patrons page is constructed using YUI. It should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-15 14:41:55 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-15 15:10:10 UTC
Bug 9420 has been pushed to master. 
Why this patch removes conflicting lines from that bug?

-<<<<<<< HEAD
...
-=======
...
->>>>>>> Bug 9420 [Revised] Work on Bootstrap for Koha
-<<<<<<< HEAD
...
->>>>>>> Bug 9420 [Revised] Work on Bootstrap for Koha
Comment 3 Owen Leonard 2013-02-15 15:41:40 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2013-02-15 15:42:32 UTC
Sorry for the bad merge errors in the previous patch!
Comment 5 Bernardo Gonzalez Kriegel 2013-02-15 15:52:00 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2013-02-17 11:14:22 UTC
Created attachment 15452 [details] [review]
[PASSED QA] Bug 9616 - Replace YUI menu on patrons page with Bootstrap

This patch converts the toolbar include file used to create the "New
patron" menu to Bootstrap, replacing YUI button and menu code
with Bootstrap markup.

To test, view any page which uses patron-toolbar.inc (members-home.pl or
circulation.pl after searching for a non-existent patron). Button and
menu should look correct and work correctly with the AddPatronLists
preference in both states.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Works as described. No errors. Looks very good!

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, no problems found.
Comment 7 Jared Camins-Esakov 2013-02-18 12:57:50 UTC
This patch has been pushed to master.